Skip to content

Commit

Permalink
netty: Not to ignore tests for window overriding
Browse files Browse the repository at this point in the history
As noted after `@Ignore`
> Re-enable once #1175 is fixed

#1175 has been closed for a long time, should re-enable the tests.
  • Loading branch information
dapengzhang0 committed Aug 14, 2017
1 parent 3795417 commit 34f31fe
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions netty/src/test/java/io/grpc/netty/NettyClientHandlerTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@
import java.util.Queue;
import java.util.concurrent.atomic.AtomicBoolean;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TestName;
Expand Down Expand Up @@ -440,7 +439,6 @@ public void channelShutdownShouldFailInFlightStreams() throws Exception {
}

@Test
@Ignore("Re-enable once https://github.com/grpc/grpc-java/issues/1175 is fixed")
public void connectionWindowShouldBeOverridden() throws Exception {
flowControlWindow = 1048576; // 1MiB
setUp();
Expand Down
2 changes: 0 additions & 2 deletions netty/src/test/java/io/grpc/netty/NettyServerHandlerTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@
import java.util.List;
import java.util.Queue;
import java.util.concurrent.TimeUnit;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
Expand Down Expand Up @@ -360,7 +359,6 @@ public void shouldAdvertiseMaxHeaderListSize() throws Exception {
}

@Test
@Ignore("Re-enable once https://github.com/grpc/grpc-java/issues/1175 is fixed")
public void connectionWindowShouldBeOverridden() throws Exception {
flowControlWindow = 1048576; // 1MiB
manualSetUp();
Expand Down

0 comments on commit 34f31fe

Please sign in to comment.