xds: add a missing test case for CallMetricRecorder and polish test d…

…ata. (#6019)
grpc · Jul 29, 2019 · 50df56f · 50df56f
1 parent 57e7bd3
commit 50df56f
Showing 1 changed file with 17 additions and 5 deletions.
diff --git a/services/src/test/java/io/grpc/services/CallMetricRecorderTest.java b/services/src/test/java/io/grpc/services/CallMetricRecorderTest.java
@@ -36,19 +36,31 @@ public void dumpGivesEmptyResultWhenNoSavedMetricValues() {
 
   @Test
   public void dumpDumpsAllSavedMetricValues() {
-    recorder.recordCallMetric("ssd", 154353.423);
-    recorder.recordCallMetric("cpu", 0.1367);
-    recorder.recordCallMetric("mem", 1437.34);
+    recorder.recordCallMetric("cost1", 154353.423);
+    recorder.recordCallMetric("cost2", 0.1367);
+    recorder.recordCallMetric("cost3", 1437.34);
 
     Map<String, Double> dump = recorder.finalizeAndDump();
     assertThat(dump)
-        .containsExactly("ssd", 154353.423, "cpu", 0.1367, "mem", 1437.34);
+        .containsExactly("cost1", 154353.423, "cost2", 0.1367, "cost3", 1437.34);
   }
 
   @Test
   public void noMetricsRecordedAfterSnapshot() {
     Map<String, Double> initDump = recorder.finalizeAndDump();
-    recorder.recordCallMetric("cpu", 154353.423);
+    recorder.recordCallMetric("cost", 154353.423);
     assertThat(recorder.finalizeAndDump()).isEqualTo(initDump);
   }
+
+  @Test
+  public void lastValueWinForMetricsWithSameName() {
+    recorder.recordCallMetric("cost1", 3412.5435);
+    recorder.recordCallMetric("cost2", 6441.341);
+    recorder.recordCallMetric("cost1", 6441.341);
+    recorder.recordCallMetric("cost1", 4654.67);
+    recorder.recordCallMetric("cost2", 75.83);
+    Map<String, Double> dump = recorder.finalizeAndDump();
+    assertThat(dump)
+        .containsExactly("cost1", 4654.67, "cost2", 75.83);
+  }
 }