Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
xds: Avoid nonexistent DNS resolution in XdsClientImplV3Test
The DNS lookups are taking considerable time on the Windows CI (~11s), which causes the test to time out: ``` Wanted but not invoked: ldsResourceWatcher.onError(<any>); -> at io.grpc.xds.XdsClientImplTestBase.sendToNonexistentHost(XdsClientImplTestBase.java:3733) Actually, there were zero interactions with this mock. at io.grpc.xds.XdsClientImplTestBase.sendToNonexistentHost(XdsClientImplTestBase.java:3733) ``` The ARM build, which uses an emulator, has had this test succeed, so the failure seems unrelated to CPU usage. We want to avoid external I/O anyway during tests, so removing the DNS lookup is good. The TSAN comment referenced XdsClientImplTestBase.sendToNonexistentHost, but the test no longer calls fakeClock.forwardTime so the comment was out-of-date. Change the comment to make clear the race involved.
- Loading branch information