-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retries: Early commit can break transparent retries #10011
Comments
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this issue
Apr 18, 2023
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this issue
Apr 19, 2023
The DECRYPTION_FAILURE_RE matcher had an exclamation point that was dropped from the related error message between Java 11 and 19. Fixes grpc#10011
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this issue
Apr 19, 2023
…ng. (grpc#10066) * retries:Remove early commit for transparent retries when no retries or no hedging remain. Fixes grpc#10011
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this issue
Apr 19, 2023
…ng. (grpc#10066) * retries:Remove early commit for transparent retries when no retries or no hedging remain. Fixes grpc#10011
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this issue
Apr 19, 2023
…ng. (grpc#10066) * retries:Remove early commit for transparent retries when no retries or no hedging remain. Fixes grpc#10011
This was referenced Apr 19, 2023
Merged
Merged
larry-safran
added a commit
that referenced
this issue
Apr 20, 2023
The DECRYPTION_FAILURE_RE matcher had an exclamation point that was dropped from the related error message between Java 11 and 19. Fixes #10011
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There is the transparent retry condition:
grpc-java/core/src/main/java/io/grpc/internal/RetriableStream.java
Lines 921 to 923 in ec9b8e0
And then within the transparent retry handling, it surprisingly looks at the hedging/retry policy:
grpc-java/core/src/main/java/io/grpc/internal/RetriableStream.java
Line 948 in ec9b8e0
That's just... wrong. There should never have been be any early commit in the transparent retry case based on the retry policy. I could understand more if this was in the normal retry/hedging flows, but those don't have the early commit. And it is good they don't, as it would break transparent retries.
Seems we should just remove all the early commits.
It may be fair to have @temawi or @larry-safran work on this, as it is easy/surgical and @YifeiZhuang reviews. Y'all can discuss amongst yoruselves.
The text was updated successfully, but these errors were encountered: