Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade runtime dependency on OKIO to 2.0.0 #10455

Closed
wu-hui opened this issue Aug 3, 2023 · 2 comments
Closed

Upgrade runtime dependency on OKIO to 2.0.0 #10455

wu-hui opened this issue Aug 3, 2023 · 2 comments

Comments

@wu-hui
Copy link

wu-hui commented Aug 3, 2023

firebase/firebase-android-sdk#5197 is reported to Firebase-Firestore because it does not work with mlkit:

com.squareup.okio:okio:2.0.0
\--- com.google.mlkit:digital-ink-recognition:18.1.0
     \--- releaseRuntimeClasspath

com.squareup.okio:okio:1.15.0 -> 2.0.0
\--- com.squareup.okhttp3:okhttp:3.12.1
     \--- com.google.mlkit:digital-ink-recognition:18.1.0
          \--- releaseRuntimeClasspath

com.squareup.okio:okio:1.17.5 -> 2.0.0
+--- releaseRuntimeClasspath
\--- io.grpc:grpc-okhttp:1.52.1
     \--- com.google.firebase:firebase-firestore:24.7.0
          +--- com.google.firebase:firebase-bom:32.2.0
          |    \--- releaseRuntimeClasspath
          \--- com.google.firebase:firebase-firestore-ktx:24.7.0
               +--- releaseRuntimeClasspath (requested com.google.firebase:firebase-firestore-ktx)
               \--- com.google.firebase:firebase-bom:32.2.0 (*)

Can we consider upgrading the grpc dependency of okio to 2.0.0 so mlkit and firestore can co-exist?

@ejona86
Copy link
Member

ejona86 commented Aug 7, 2023

We've already upgraded okio to 2.10.0 in #10359. I wasn't aware there was an ABI issue with okio 2.x, otherwise we would have upgraded much sooner. I had tested forever ago and there was no API issue.

The change will be part of 1.58, scheduled for Sept 5th.

@ejona86 ejona86 closed this as completed Aug 7, 2023
@ejona86
Copy link
Member

ejona86 commented Aug 7, 2023

Actually, I don't see any ABI issue here. You might try a later version of okio than 2.0. I just checked okio 2.10.0 and it has the method the error claimed didn't exist:

$ javap BufferedSource.class | grep getBuffer
  public abstract okio.Buffer getBuffer();

That is "getBuffer()Lokio/Buffer; in class Lokio/BufferedSource;"

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants