Upgrade dependencies post v1.57.x branch cut #10359

sergiitk · 2023-07-07T22:29:53Z

Dependency updates

Update successfully to the latest

Updated to non-latest

com.squareup.okio:okio 1.17.5 -> ~~3.4.0~~ 2.10.0 -- updating to 3.x failed due to them introducing gradle multiplatform artifacts. Error in the comment below.
org.checkerframework:checker-qual 3.33.0 -> ~~3.36.0~~ -- removed, no longer needed
Mockito - updated to 4.11.0. Versions 5.x break some tests. Errors in the comment below.
- org.mockito:mockito-android 3.12.4 -> ~~5.4.0~~ 4.11.0
- org.mockito:mockito-core 3.12.4 -> ~~5.4.0~~ 4.11.0

Not updated

Cronet -- upgrade failed, created a blocker ticket grpc-cronet: ExperimentalBidirectionalStream, ExperimentalCronetEngine are deprecated #10396
- ~~org.chromium.net:cronet-api 108.5359.79 -> 113.5672.61~~
- ~~org.chromium.net:cronet-embedded 108.5359.79 -> 113.5672.61~~
Google auth -- upgrade blocked by Revert "auth: Add support for Retryable interface" #9118
- ~~com.google.auth:google-auth-library-credentials 1.4.0 -> 1.19.0~~
- ~~com.google.auth:google-auth-library-oauth2-http 1.4.0 -> 1.19.0~~
Guava -- not upgraded: 32.1.0 broke gradle modules
- ~~libs.guava = com.google.guava:guava 32.0.1-android -> 32.1.1-jre~~
- ~~libs.guava.jre = com.google.guava:guava 32.0.1-jre -> 32.1.1-jre~~
- ~~libs.guava.testlib = com.google.guava:guava-testlib 32.0.1-android -> 32.1.1-jre~~

Contributor's log

checkForUpdates results (at the time of PR creation)

Important: this is not an actual list of updated dependencies.

> Task :checkForUpdates
androidx.core:core 1.10.0 -> 1.10.1
com.google.auto.value:auto-value 1.10.1 -> 1.10.2
com.google.auto.value:auto-value-annotations 1.10.1 -> 1.10.2
org.checkerframework:checker-qual 3.33.0 -> 3.36.0
com.puppycrawl.tools:checkstyle 8.28 -> 10.12.1
org.chromium.net:cronet-api 108.5359.79 -> 113.5672.61
org.chromium.net:cronet-embedded 108.5359.79 -> 113.5672.61
com.google.errorprone:error_prone_annotations 2.18.0 -> 2.20.0
com.google.errorprone:error_prone_core 2.18.0 -> 2.20.0
com.google.errorprone:error_prone_core 2.10.0 -> 2.20.0
com.google.api.grpc:proto-google-common-protos 2.17.0 -> 2.22.0
com.google.auth:google-auth-library-credentials 1.4.0 -> 1.19.0
com.google.auth:google-auth-library-oauth2-http 1.4.0 -> 1.19.0
com.google.cloud:google-cloud-logging 3.14.5 -> 3.15.5
com.google.guava:guava 32.0.1-android -> 32.1.1-jre
com.google.guava:guava 32.0.1-jre -> 32.1.1-jre
com.google.guava:guava-testlib 32.0.1-android -> 32.1.1-jre
org.mockito:mockito-android 3.12.4 -> 5.4.0
org.mockito:mockito-core 3.12.4 -> 5.4.0
com.squareup.okio:okio 1.17.5 -> 3.4.0
com.google.protobuf:protobuf-java 3.22.3 -> 3.23.4
com.google.protobuf:protobuf-java-util 3.22.3 -> 3.23.4
com.google.protobuf:protobuf-javalite 3.22.3 -> 3.23.4
com.google.protobuf:protoc 3.22.3 -> 3.23.4
org.robolectric:robolectric 4.9.2 -> 4.10.3
com.google.truth:truth 1.0.1 -> 1.1.5

sergiitk · 2023-07-12T16:15:20Z

Mockito 5.4.0 failures

> Task :grpc-core:test

io.grpc.internal.AbstractReadableBufferTest > readNegativeIntShouldSucceed FAILED
    java.lang.AssertionError: expected:<-1122868> but was:<0>
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:647)
        at org.junit.Assert.assertEquals(Assert.java:633)
        at io.grpc.internal.AbstractReadableBufferTest.readNegativeIntShouldSucceed(AbstractReadableBufferTest.java:52)

io.grpc.internal.AbstractReadableBufferTest > readPositiveIntShouldSucceed FAILED
    java.lang.AssertionError: expected:<2146360780> but was:<0>
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:647)
        at org.junit.Assert.assertEquals(Assert.java:633)
        at io.grpc.internal.AbstractReadableBufferTest.readPositiveIntShouldSucceed(AbstractReadableBufferTest.java:46)

> Task :grpc-grpclb:test FAILED

io.grpc.grpclb.CachedSubchannelPoolTest > returnDuplicateAddressSubchannel FAILED
    value of    : getPendingTasks(...).size()
    expected    : 2
    but was     : 1
    iterable was: [[due=10000000000, task=io.grpc.grpclb.CachedSubchannelPool$ShutdownSubchannelTask@5c0f508b(scheduled in SynchronizationContext)]]
        at app//io.grpc.grpclb.CachedSubchannelPoolTest.returnDuplicateAddressSubchannel(CachedSubchannelPoolTest.java:243)

io.grpc.grpclb.CachedSubchannelPoolTest > clear FAILED
    org.mockito.exceptions.verification.NeverWantedButInvoked:
    subchannel.shutdown();
    Never wanted here:
    -> at io.grpc.grpclb.CachedSubchannelPoolTest.clear(CachedSubchannelPoolTest.java:262)
    But invoked here:
    -> at io.grpc.grpclb.CachedSubchannelPool.returnSubchannel(CachedSubchannelPool.java:109) with arguments: []
        at app//io.grpc.grpclb.CachedSubchannelPoolTest.clear(CachedSubchannelPoolTest.java:262)

io.grpc.grpclb.CachedSubchannelPoolTest > subchannelReused FAILED
    value of                  : takeOrCreateSubchannel(...)
    expected specific instance: Mock for Subchannel, hashCode: 1501191853
    but was                   : Mock for Subchannel, hashCode: 556084207
        at app//io.grpc.grpclb.CachedSubchannelPoolTest.subchannelReused(CachedSubchannelPoolTest.java:196)

io.grpc.grpclb.GrpclbLoadBalancerTest > grpclbFallback_timeout_timerExpires FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.subtestGrpclbFallbackTimeout(GrpclbLoadBalancerTest.java:1211)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.grpclbFallback_timeout_timerExpires(GrpclbLoadBalancerTest.java:1192)

io.grpc.grpclb.GrpclbLoadBalancerTest > grpclbBalancerStreamClosedAndRetried FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there were exactly 6 interactions with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)

    helper.getSynchronizationContext();
    -> at io.grpc.grpclb.GrpclbState.<init>(GrpclbState.java:201)

    helper.getScheduledExecutorService();
    -> at io.grpc.grpclb.GrpclbState.<init>(GrpclbState.java:217)

    helper.getAuthority();
    -> at io.grpc.grpclb.GrpclbState.<init>(GrpclbState.java:222)

    helper.getChannelLogger();
    -> at io.grpc.grpclb.GrpclbState.<init>(GrpclbState.java:225)

    helper.createOobChannel(
        [[[FakeSocketAddress-fake-address-0]/{io.grpc.grpclb.GrpclbConstants.ATTR_LB_ADDR_AUTHORITY=lb.google.com, io.grpc.EquivalentAddressGroup.ATTR_AUTHORITY_OVERRIDE=lb.google.com}]],
        "lb.google.com-notIntendedToBeUsed"
    );
    -> at io.grpc.grpclb.GrpclbState.startLbComm(GrpclbState.java:378)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.grpclbBalancerStreamClosedAndRetried(GrpclbLoadBalancerTest.java:1798)

io.grpc.grpclb.GrpclbLoadBalancerTest > grpclbFallback_subchannelsLost FAILED
    org.mockito.exceptions.verification.VerificationInOrderFailure:
    Verification in order failure
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
    Wanted anywhere AFTER following interaction:
    helper.createOobChannel(
        [[[FakeSocketAddress-fake-address-0]/{io.grpc.grpclb.GrpclbConstants.ATTR_LB_ADDR_AUTHORITY=lb.google.com, io.grpc.EquivalentAddressGroup.ATTR_AUTHORITY_OVERRIDE=lb.google.com}]],
        "lb.google.com-notIntendedToBeUsed"
    );
    -> at io.grpc.grpclb.GrpclbState.startLbComm(GrpclbState.java:378)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.subtestGrpclbFallbackConnectionLost(GrpclbLoadBalancerTest.java:1534)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.grpclbFallback_subchannelsLost(GrpclbLoadBalancerTest.java:1509)

io.grpc.grpclb.GrpclbLoadBalancerTest > switchServiceName FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.switchServiceName(GrpclbLoadBalancerTest.java:2425)

io.grpc.grpclb.GrpclbLoadBalancerTest > pickFirstMode_defaultTimeout_fallback FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.pickFirstModeFallback(GrpclbLoadBalancerTest.java:2175)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.pickFirstMode_defaultTimeout_fallback(GrpclbLoadBalancerTest.java:2156)

io.grpc.grpclb.GrpclbLoadBalancerTest > abundantInitialResponse FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.abundantInitialResponse(GrpclbLoadBalancerTest.java:642)

io.grpc.grpclb.GrpclbLoadBalancerTest > pickFirstMode_serviceConfigTimeout_fallback FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.pickFirstModeFallback(GrpclbLoadBalancerTest.java:2175)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.pickFirstMode_serviceConfigTimeout_fallback(GrpclbLoadBalancerTest.java:2161)

io.grpc.grpclb.GrpclbLoadBalancerTest > switchMode_nullLbPolicy FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.switchMode_nullLbPolicy(GrpclbLoadBalancerTest.java:2338)

io.grpc.grpclb.GrpclbLoadBalancerTest > roundRobinMode_subchannelStayTransientFailureUntilReady FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.roundRobinMode_subchannelStayTransientFailureUntilReady(GrpclbLoadBalancerTest.java:1133)

io.grpc.grpclb.GrpclbLoadBalancerTest > switchMode FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.switchMode(GrpclbLoadBalancerTest.java:2250)

io.grpc.grpclb.GrpclbLoadBalancerTest > raceBetweenHandleAddressesAndLbStreamClosure FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.raceBetweenHandleAddressesAndLbStreamClosure(GrpclbLoadBalancerTest.java:679)

io.grpc.grpclb.GrpclbLoadBalancerTest > grpclbFallback_breakLbStreamBeforeFallbackTimerExpires FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.grpclbFallback_breakLbStreamBeforeFallbackTimerExpires(GrpclbLoadBalancerTest.java:1363)

io.grpc.grpclb.GrpclbLoadBalancerTest > grpclbFallback_initialTimeout_timerExpires FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.subtestGrpclbFallbackTimeout(GrpclbLoadBalancerTest.java:1211)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.grpclbFallback_initialTimeout_timerExpires(GrpclbLoadBalancerTest.java:1182)

io.grpc.grpclb.GrpclbLoadBalancerTest > grpclbWorking FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.grpclbWorking(GrpclbLoadBalancerTest.java:910)

io.grpc.grpclb.GrpclbLoadBalancerTest > grpclbWorking_pickFirstMode FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.grpclbWorking_pickFirstMode(GrpclbLoadBalancerTest.java:1900)

io.grpc.grpclb.GrpclbLoadBalancerTest > grpclbFallback_initialTimeout_serverListReceivedBeforeTimerExpires FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.subtestGrpclbFallbackTimeout(GrpclbLoadBalancerTest.java:1211)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.grpclbFallback_initialTimeout_serverListReceivedBeforeTimerExpires(GrpclbLoadBalancerTest.java:1177)

io.grpc.grpclb.GrpclbLoadBalancerTest > grpclbThenNameResolutionFails FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.grpclbThenNameResolutionFails(GrpclbLoadBalancerTest.java:826)

io.grpc.grpclb.GrpclbLoadBalancerTest > loadReporting FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.loadReporting(GrpclbLoadBalancerTest.java:423)

io.grpc.grpclb.GrpclbLoadBalancerTest > grpclbFallback_allLost FAILED
    org.mockito.exceptions.verification.VerificationInOrderFailure:
    Verification in order failure
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
    Wanted anywhere AFTER following interaction:
    helper.createOobChannel(
        [[[FakeSocketAddress-fake-address-0]/{io.grpc.grpclb.GrpclbConstants.ATTR_LB_ADDR_AUTHORITY=lb.google.com, io.grpc.EquivalentAddressGroup.ATTR_AUTHORITY_OVERRIDE=lb.google.com}]],
        "lb.google.com-notIntendedToBeUsed"
    );
    -> at io.grpc.grpclb.GrpclbState.startLbComm(GrpclbState.java:378)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.subtestGrpclbFallbackConnectionLost(GrpclbLoadBalancerTest.java:1534)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.grpclbFallback_allLost(GrpclbLoadBalancerTest.java:1514)

io.grpc.grpclb.GrpclbLoadBalancerTest > shutdownWithoutSubchannel_pickFirst FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.subtestShutdownWithoutSubchannel(GrpclbLoadBalancerTest.java:2142)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.shutdownWithoutSubchannel_pickFirst(GrpclbLoadBalancerTest.java:2133)

io.grpc.grpclb.GrpclbLoadBalancerTest > grpclbWorking_pickFirstMode_lbSendsEmptyAddress FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.grpclbWorking_pickFirstMode_lbSendsEmptyAddress(GrpclbLoadBalancerTest.java:2021)

io.grpc.grpclb.GrpclbLoadBalancerTest > grpclbFallback_allLost_failToFallback FAILED
    org.mockito.exceptions.verification.VerificationInOrderFailure:
    Verification in order failure
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
    Wanted anywhere AFTER following interaction:
    helper.createOobChannel(
        [[[FakeSocketAddress-fake-address-0]/{io.grpc.grpclb.GrpclbConstants.ATTR_LB_ADDR_AUTHORITY=lb.google.com, io.grpc.EquivalentAddressGroup.ATTR_AUTHORITY_OVERRIDE=lb.google.com}]],
        "lb.google.com-notIntendedToBeUsed"
    );
    -> at io.grpc.grpclb.GrpclbState.startLbComm(GrpclbState.java:378)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.grpclbFallback_allLost_failToFallback(GrpclbLoadBalancerTest.java:1624)

io.grpc.grpclb.GrpclbLoadBalancerTest > nameResolutionFailsThenRecover FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.nameResolutionFailsThenRecover(GrpclbLoadBalancerTest.java:812)

io.grpc.grpclb.GrpclbLoadBalancerTest > grpclbFallback_balancerLost FAILED
    org.mockito.exceptions.verification.VerificationInOrderFailure:
    Verification in order failure
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
    Wanted anywhere AFTER following interaction:
    helper.createOobChannel(
        [[[FakeSocketAddress-fake-address-0]/{io.grpc.grpclb.GrpclbConstants.ATTR_LB_ADDR_AUTHORITY=lb.google.com, io.grpc.EquivalentAddressGroup.ATTR_AUTHORITY_OVERRIDE=lb.google.com}]],
        "lb.google.com-notIntendedToBeUsed"
    );
    -> at io.grpc.grpclb.GrpclbState.startLbComm(GrpclbState.java:378)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.subtestGrpclbFallbackConnectionLost(GrpclbLoadBalancerTest.java:1534)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.grpclbFallback_balancerLost(GrpclbLoadBalancerTest.java:1504)

io.grpc.grpclb.GrpclbLoadBalancerTest > grpclbWorking_lbSendsFallbackMessage FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.grpclbWorking_lbSendsFallbackMessage(GrpclbLoadBalancerTest.java:2495)

io.grpc.grpclb.GrpclbLoadBalancerTest > grpclbFallback_timeout_serverListReceivedBeforeTimerExpires FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.subtestGrpclbFallbackTimeout(GrpclbLoadBalancerTest.java:1211)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.grpclbFallback_timeout_serverListReceivedBeforeTimerExpires(GrpclbLoadBalancerTest.java:1187)

io.grpc.grpclb.GrpclbLoadBalancerTest > raceBetweenLoadReportingAndLbStreamClosure FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.raceBetweenLoadReportingAndLbStreamClosure(GrpclbLoadBalancerTest.java:724)

io.grpc.grpclb.GrpclbLoadBalancerTest > shutdownWithoutSubchannel_roundRobin FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.subtestShutdownWithoutSubchannel(GrpclbLoadBalancerTest.java:2142)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.shutdownWithoutSubchannel_roundRobin(GrpclbLoadBalancerTest.java:2128)

io.grpc.grpclb.GrpclbLoadBalancerTest > useIndependentRpcContext FAILED
    Wanted but not invoked:
    loadBalancerImplBase.balanceLoad(
        <Capturing argument: StreamObserver>
    );
    -> at io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)

    However, there was exactly 1 interaction with this mock:
    loadBalancerImplBase.bindService();
    -> at io.grpc.internal.ServerImplBuilder.addService(ServerImplBuilder.java:143)
        at app//io.grpc.lb.v1.LoadBalancerGrpc$AsyncService.balanceLoad(LoadBalancerGrpc.java:104)
        at app//io.grpc.grpclb.GrpclbLoadBalancerTest.useIndependentRpcContext(GrpclbLoadBalancerTest.java:2683)

73 tests completed, 32 failed

> Task :grpc-census:test

io.grpc.census.CensusModulesTest > traceHeadersPropagateSpanContext FAILED
    org.mockito.exceptions.misusing.InvalidUseOfMatchersException:
    Invalid use of argument matchers!
    0 matchers expected, 1 recorded:
    -> at io.grpc.census.CensusModulesTest.traceHeadersPropagateSpanContext(CensusModulesTest.java:1071)

    This exception may occur if matchers are combined with raw values:
        //incorrect:
        someMethod(any(), "raw String");
    When using matchers, all arguments have to be provided by matchers.
    For example:
        //correct:
        someMethod(any(), eq("String by matcher"));

    For more info see javadoc for Matchers class.
        at app//io.opencensus.trace.Span.getContext(Span.java:254)
        at app//io.grpc.census.CensusModulesTest.traceHeadersPropagateSpanContext(CensusModulesTest.java:1071)

37 tests completed, 1 failed

> Task :grpc-census:test FAILED

> Task :grpc-core:test FAILED

1100 tests completed, 2 failed, 3 skipped

sergiitk · 2023-07-12T16:27:48Z

Okio 3.4.0 update failure

Execution failed for task ':grpc-all:checkUpperBoundDeps'.
Maven version skew: com.squareup.okio:okio (3.4.0 != null) Bad version dependency path: [project ':grpc-all', io.grpc:grpc-okhttp:1.58.0-SNAPSHOT] Run './gradlew :grpc-all:dependencies --configuration runtimeClasspath' to diagnose

* What went wrong: Execution failed for task ':grpc-api:compileJava'. > StringCaseLocaleUsage is not a valid checker name

sergiitk · 2023-07-20T19:02:30Z

api/src/main/java/io/grpc/ServerInterceptors.java

-          protected ServerCall<WReqT, WRespT> delegate() {
-            return call;
-          }
+              @Override


Have to leave this as is - diamond notation does not work with anonymous classes in java 8.

netty/src/main/java/io/grpc/netty/NettyServer.java

ejona86 · 2023-07-28T21:42:29Z

@sergiitk, this made a change to the README when bumping protoc. We should undo that change and wait for the next release before updating the README.

The README describes the released version of gRPC. But the most recent release doesn't use protobuf 3.23.4. Telling people to use protoc 3.23.4 is asking for breakages because they will be running with protobuf-java 3.22.3, which is a downgrade. The bump to 3.23.4 was incorrectly done in grpc#10359.

The README describes the released version of gRPC. But the most recent release doesn't use protobuf 3.23.4. Telling people to use protoc 3.23.4 is asking for breakages because they will be running with protobuf-java 3.22.3, which is a downgrade. The bump to 3.23.4 was incorrectly done in #10359.

The README describes the released version of gRPC. But the most recent release doesn't use protobuf 3.23.4. Telling people to use protoc 3.23.4 is asking for breakages because they will be running with protobuf-java 3.22.3, which is a downgrade. The bump to 3.23.4 was incorrectly done in grpc#10359.

sergiitk force-pushed the upgrade-deps branch 2 times, most recently from e10de42 to 1ffb3b4 Compare July 11, 2023 23:16

sergiitk force-pushed the upgrade-deps branch 3 times, most recently from 80f938b to 04041c8 Compare July 19, 2023 23:04

Patch-level updates + resolving observability deps

665f017

sergiitk force-pushed the upgrade-deps branch 2 times, most recently from 8663fe3 to c58a943 Compare July 20, 2023 00:35

sergiitk mentioned this pull request Jul 20, 2023

grpc-cronet: ExperimentalBidirectionalStream, ExperimentalCronetEngine are deprecated #10396

Closed

sergiitk added 15 commits July 19, 2023 18:25

Update protobuf version in examples

a7f97fa

update cronet

cc716a0

downgrade cronet, bump okio to 2.10

94b294c

update robolectric

c163ff3

Update mockito to 4.11.0

4733937

Update truth

f2ad321

Update checkstyle to 8.36.2

f6a8828

Update checkstyle to 8.40

155c993

Update checkstyle to 8.41.1

aac41fb

Upgrade errorprone to 2.20.0

93cd414

Address errorprone compatibility with projects using corejava8

7960a96

* What went wrong: Execution failed for task ':grpc-api:compileJava'. > StringCaseLocaleUsage is not a valid checker name

Delete org.checkerframework:checker-qual dependency

5b19001

undo wrong idents

3e31718

Update checkstyle to the latest

5123afb

checkstyle dropped java8 support

ed70c55

sergiitk force-pushed the upgrade-deps branch from c58a943 to 773c9c2 Compare July 20, 2023 01:25

Document update nuances

69e6a48

sergiitk force-pushed the upgrade-deps branch from 773c9c2 to 69e6a48 Compare July 20, 2023 18:33

sergiitk changed the title ~~Upgrade dependencies prior v1.57.x branch cut~~ Upgrade dependencies post v1.57.x branch cut Jul 20, 2023

sergiitk commented Jul 20, 2023

View reviewed changes

sergiitk force-pushed the upgrade-deps branch 4 times, most recently from da0bcd5 to 5751767 Compare July 20, 2023 20:54

Miminize changes needed to comply with updated checkstyle

a9adde4

sergiitk force-pushed the upgrade-deps branch from 5751767 to a9adde4 Compare July 20, 2023 23:39

Update bazel repositories

8a338b3

sergiitk marked this pull request as ready for review July 20, 2023 23:59

sergiitk requested a review from ejona86 July 20, 2023 23:59

ejona86 approved these changes Jul 21, 2023

View reviewed changes

netty/src/main/java/io/grpc/netty/NettyServer.java Show resolved Hide resolved

sergiitk merged commit 419767f into grpc:master Jul 21, 2023
14 checks passed

sergiitk deleted the upgrade-deps branch July 21, 2023 17:15

ejona86 mentioned this pull request Jul 28, 2023

README.md: Revert reference to protobuf 3.23.4 #10430

Merged

This was referenced Aug 7, 2023

Upgrade runtime dependency on OKIO to 2.0.0 #10455

Closed

Okio CVE-2023-3635 #10456

Closed

temawi mentioned this pull request Oct 9, 2023

android_interop CI is crashing #10457

Open

github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade dependencies post v1.57.x branch cut #10359

Upgrade dependencies post v1.57.x branch cut #10359

sergiitk commented Jul 7, 2023 •

edited

sergiitk commented Jul 12, 2023 •

edited

sergiitk commented Jul 12, 2023 •

edited

sergiitk Jul 20, 2023

ejona86 commented Jul 28, 2023

Upgrade dependencies post v1.57.x branch cut #10359

Upgrade dependencies post v1.57.x branch cut #10359

Conversation

sergiitk commented Jul 7, 2023 • edited

Dependency updates

Update successfully to the latest

Updated to non-latest

Not updated

Contributor's log

sergiitk commented Jul 12, 2023 • edited

Mockito 5.4.0 failures

sergiitk commented Jul 12, 2023 • edited

Okio 3.4.0 update failure

sergiitk Jul 20, 2023

Choose a reason for hiding this comment

ejona86 commented Jul 28, 2023

sergiitk commented Jul 7, 2023 •

edited

sergiitk commented Jul 12, 2023 •

edited

sergiitk commented Jul 12, 2023 •

edited