Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SERVLET] Unnecessary bytes to hex string conversion for FINE logging #11031

Closed
hypnoce opened this issue Mar 22, 2024 · 3 comments
Closed

[SERVLET] Unnecessary bytes to hex string conversion for FINE logging #11031

hypnoce opened this issue Mar 22, 2024 · 3 comments

Comments

@hypnoce
Copy link
Contributor

hypnoce commented Mar 22, 2024

What version of gRPC-Java are you using?

1.60.0

What is your environment?

MacOS JDK17

What did you expect to see?

Hex string conversion in when the level is actually FINE:

log.finest("outbound data: length={0}, bytes={1}", numBytes, toHexString(bytes, numBytes));

What did you see instead?

Hex string conversion before checking log level

Steps to reproduce the bug

@ejona86
Copy link
Member

ejona86 commented Mar 22, 2024

Yep. That should be an easy fix. Would you be interested in sending a PR?

@hypnoce
Copy link
Contributor Author

hypnoce commented Mar 22, 2024

The PR is opened : #11032

@ejona86
Copy link
Member

ejona86 commented Mar 22, 2024

Oh, the "Fixes X" in is the subject, not in the body, so it didn't link back to this. (Thank you!)

@ejona86 ejona86 modified the milestones: Next, 1.64 Mar 25, 2024
@ejona86 ejona86 added TODO:backport PR needs to be backported. Removed after backport complete and removed TODO:backport PR needs to be backported. Removed after backport complete labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants