Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPC tests fail and hang with JDK 1.8.0_73 #1497

Closed
matthild opened this issue Feb 29, 2016 · 7 comments
Closed

GRPC tests fail and hang with JDK 1.8.0_73 #1497

matthild opened this issue Feb 29, 2016 · 7 comments
Assignees
Labels
Milestone

Comments

@matthild
Copy link
Contributor

Making the following change in build.gradle gets everything working again:

-        def alpnboot_version = '8.1.2.v20141202'
+        def alpnboot_version = '8.1.7.v20160121'

However, doing so would probably break the build for developers using an old JDK and for Travis.

Should the current logic for choosing the ALPN version accommodate more than one version of Java 8, or is the current approach intentional?

@ejona86
Copy link
Member

ejona86 commented Mar 1, 2016

It should accommodate more than one version of Java 8.

@hsaliak
Copy link
Contributor

hsaliak commented Apr 26, 2016

This only affects building gRPC from source. Does not affect people using gRPC packages.

@ejona86
Copy link
Member

ejona86 commented Apr 28, 2016

@ejona86
Copy link
Member

ejona86 commented Apr 28, 2016

@ejona86
Copy link
Member

ejona86 commented Apr 28, 2016

A quick attempt looks like it may work.

diff --git a/build.gradle b/build.gradle
index 2f7b20f..cc0ec46 100644
--- a/build.gradle
+++ b/build.gradle
@@ -164,6 +164,7 @@ subprojects {
     // Define a separate configuration for managing the dependency on Jetty alpnboot jar.
     configurations {
         alpnboot
+        alpnagent
         tcnative
     }

@@ -172,7 +173,8 @@ subprojects {
                     libraries.mockito

         // Configuration for modules that use Jetty ALPN
         alpnboot alpnboot_package_name
+        alpnagent 'org.mortbay.jetty.alpn:jetty-alpn-agent:2.0.2'

         // Configuration for modules that use Netty tcnative (for OpenSSL).
         tcnative libraries.netty_tcnative
diff --git a/netty/build.gradle b/netty/build.gradle
index 7f76b0c..4677048 100644
--- a/netty/build.gradle
+++ b/netty/build.gradle
@@ -9,7 +9,7 @@ dependencies {
 }

 test {
-    jvmArgs "-Xbootclasspath/p:" + configurations.alpnboot.asPath
+    jvmArgs "-javaagent:" + configurations.alpnagent.asPath
 }

 javadoc.options.links 'http://netty.io/4.1/api/'

@dapengzhang0
Copy link
Member

resolve by the commit: use Jetty ALPN agent instead of Jetty ALPN #1760

@ejona86 ejona86 modified the milestones: 1.0, 0.15.0 Jul 1, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Sep 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants