Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not pass ClassLoader to Class.forName, for Android #2633

Closed
ejona86 opened this issue Jan 20, 2017 · 0 comments
Closed

Do not pass ClassLoader to Class.forName, for Android #2633

ejona86 opened this issue Jan 20, 2017 · 0 comments
Assignees
@ejona86
Labels
android bug
Milestone
1.6

Comments

@ejona86
Copy link
Member

ejona86 commented Jan 20, 2017

See #2207. An easy workaround for #2207 was to specify -keep in ProGuard configuration. However, everyone would be happier if such configuration was unnecessary. Using forName() without passing ClassLoader should remove the need for configuration, as originally intended.
@ejona86 ejona86 added this to the Next milestone Jan 20, 2017
@ejona86 ejona86 self-assigned this Jan 20, 2017
ejona86 added a commit to ejona86/grpc-java that referenced this issue Jan 20, 2017
@ejona86
android: Fix ProGuard rules in Android apps
ba52076 
Fixes grpc#2207. This is actually a workaround. Ideally users shouldn't need
to -keep classes, but it's a bit risky to fix the real issue before 1.1.
The further fix will be done as part of grpc#2633.

The interop app's build.gradle change is necessary to compile with newer
Gradle versions. The com.google.errorprone.annotations was necessary in
order to prevent annotation warnings from failing the build.
@ejona86 ejona86 mentioned this issue Jan 21, 2017
Merged
ejona86 added a commit that referenced this issue Jan 23, 2017
@ejona86
android: Fix ProGuard rules in Android apps
06c40dc 
Fixes #2207. This is actually a workaround. Ideally users shouldn't need
to -keep classes, but it's a bit risky to fix the real issue before 1.1.
The further fix will be done as part of #2633.

The interop app's build.gradle change is necessary to compile with newer
Gradle versions. The com.google.errorprone.annotations was necessary in
order to prevent annotation warnings from failing the build.
@ejona86 ejona86 mentioned this issue Jun 30, 2017
Closed
ejona86 added a commit to ejona86/grpc-java that referenced this issue Jul 14, 2017
@ejona86
core: Use Class.forName(String) in provider for Android
ce490c4 
Class.forName(String) is understood by ProGuard, removing the need for
manual ProGuard configuration and allows ProGuard to rename the provider
classes. Previously the provider classes could not be renamed.

Fixes grpc#2633
ejona86 added a commit to ejona86/grpc-java that referenced this issue Jul 14, 2017
@ejona86
core: Use Class.forName(String) in provider for Android
305eadb 
Class.forName(String) is understood by ProGuard, removing the need for
manual ProGuard configuration and allows ProGuard to rename the provider
classes. Previously the provider classes could not be renamed.

Fixes grpc#2633
@ejona86 ejona86 mentioned this issue Jul 14, 2017
Merged
ejona86 added a commit that referenced this issue Jul 19, 2017
@ejona86
core: Use Class.forName(String) in provider for Android
d325919 
Class.forName(String) is understood by ProGuard, removing the need for
manual ProGuard configuration and allows ProGuard to rename the provider
classes. Previously the provider classes could not be renamed.

Fixes #2633
@ejona86 ejona86 modified the milestones: 1.6, Next Jul 27, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Sep 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ejona86 ejona86

Labels
android bug
Projects
None yet
Milestone
1.6
Development

No branches or pull requests
1 participant
@ejona86