ManagedChannel getState/notifyChanged API docs

[dcow]

I'm using gRPC 1.7 (on Android) and notice the docs for ManagedChannel still say this functionality is unimplemented (and the base implementation throws as it should). However, the MannagedChannelImpl (which OkHttpChannelImpleBuilder uses) has this implemented. Is this an oversight or on purpose? It caused me to dive into the issues (culminating in #2292) to figure out if this was actually supported yet (I've determined it is). Should the docs be updated to something a little more helpful?

[carl-mastrangelo]

We don't own all implementations of ManagedChannel, so we cannot be certain all implementations do. The only known implementation, ManagedChannelImpl, does implement it. Using ManagedChannelBuilders written by the gRPC team will implement these methods.

[dcow]

Understood, but the docs still say it's not implemented and have links to closed issues ( #28 and #2292 ).

* <p><strong>Warning</strong>: this API is not yet implemented by the gRPC library (<a
* href="https://github.com/grpc/grpc-java/issues/2292" target="_blank">issue on github</a>).

That's the main thing that threw me for a loop. Maybe a forward reference to ManagedChannelImpl or some prose similar your comment explaining the situation would be useful. I'm happy to contribute, but want to make sure I wasn't misunderstanding the situation.

[carl-mastrangelo]

@dapengzhang0 Do you know if the Channel state APIs are complete an implemented everywhere? Can the warning be removed?

[dapengzhang0]

The warning should be removed since the API is implemented in the main impl of ManacheChannel in the gRPC library.

[ejona86]

Fixed by #3768