Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offloadExecutor is experimental API #6279

Closed
ejona86 opened this issue Oct 15, 2019 · 3 comments · Fixed by #9931
Closed

offloadExecutor is experimental API #6279

ejona86 opened this issue Oct 15, 2019 · 3 comments · Fixed by #9931
Assignees
@larry-safran
Labels
experimental API Issue tracks stabilizing an experimental API
Milestone
1.54

Comments

@ejona86
Copy link
Member

ejona86 commented Oct 15, 2019 •
edited

ManagedChannelBuilder.offloadExecutor()
NameResolver.Args setOffloadExecutor()/getOffloadExecutor()

Was originally added in #6238 (was renamed from blockingExecutor)
@ejona86 ejona86 added the experimental API Issue tracks stabilizing an experimental API label Oct 15, 2019
@ejona86 ejona86 added this to the Next milestone Oct 15, 2019
@ejona86
Copy link
Member Author

ejona86 commented Oct 17, 2019

API review:

  • Rename to offloadExecutor

CC @groakley, FYI

@groakley groakley mentioned this issue Oct 21, 2019
Closed
ejona86 added a commit to ejona86/grpc-java that referenced this issue Nov 4, 2019
@ejona86
api: Rename blockingExecutor to offloadExecutor
5c021aa 
The API review for grpc#6279 came up with a more meaningful name that
better explains the intent. A setter for the old name was left in
ManagedChannelBuilder to ease migration to the new name by current
users.
@ejona86 ejona86 mentioned this issue Nov 4, 2019
Merged
ejona86 added a commit that referenced this issue Nov 4, 2019
@ejona86
api: Rename blockingExecutor to offloadExecutor
4dba65b 
The API review for #6279 came up with a more meaningful name that
better explains the intent. A setter for the old name was left in
ManagedChannelBuilder to ease migration to the new name by current
users.
ejona86 added a commit to ejona86/grpc-java that referenced this issue Nov 4, 2019
@ejona86
api: Rename blockingExecutor to offloadExecutor
94aa168 
The API review for grpc#6279 came up with a more meaningful name that
better explains the intent. A setter for the old name was left in
ManagedChannelBuilder to ease migration to the new name by current
users.
@ejona86 ejona86 mentioned this issue Nov 4, 2019
Merged
ejona86 added a commit that referenced this issue Nov 4, 2019
@ejona86
api: Rename blockingExecutor to offloadExecutor
78efc8b 
The API review for #6279 came up with a more meaningful name that
better explains the intent. A setter for the old name was left in
ManagedChannelBuilder to ease migration to the new name by current
users.
@ejona86 ejona86 changed the title blockingExecutor is experimental API offloadExecutor is experimental API Apr 30, 2020
@dapengzhang0 dapengzhang0 mentioned this issue Aug 6, 2020
Merged
dfawley pushed a commit to dfawley/grpc-java that referenced this issue Jan 15, 2021
@ejona86 @dfawley
api: Rename blockingExecutor to offloadExecutor
c990fcc 
The API review for grpc#6279 came up with a more meaningful name that
better explains the intent. A setter for the old name was left in
ManagedChannelBuilder to ease migration to the new name by current
users.
@ejona86
Copy link
Member Author

ejona86 commented Jun 6, 2022

CallCredentials needs to use offload executor. We should fix CallCredentials in ManagedChannelImpl and wait a release before stabilizing offload exeuctor.

larry-safran added a commit to larry-safran/grpc-java that referenced this issue Jun 10, 2022
@larry-safran
Change the construction of CallCredentialsApplyingTransportFactory in…
116cfd9 
… ManagedChannelImpl

to use the offloadExecutor as indicated in grpc#6279 (comment) .
ejona86 pushed a commit that referenced this issue Jun 15, 2022
@larry-safran
core: Use offloadExecutor for CallCredentials (#9263)
8e77936 
Change the construction of CallCredentialsApplyingTransportFactory in
ManagedChannelImpl to use the offloadExecutor as indicated in
#6279 (comment) .
larry-safran added a commit to larry-safran/grpc-java that referenced this issue Jun 28, 2022
@larry-safran
Change the construction of CallCredentialsApplyingTransportFactory in…
a11e54a 
… ManagedChannelImpl

to use the offloadExecutor as indicated in grpc#6279 (comment) .
@larry-safran
Copy link
Contributor

Ready to stabilize per meeting.

@larry-safran larry-safran self-assigned this Feb 15, 2023
larry-safran added a commit to larry-safran/grpc-java that referenced this issue Mar 4, 2023
@larry-safran
api:Stabalize offloadExecutor.
0a8fd94 
fixes grpc#6279
@larry-safran larry-safran mentioned this issue Mar 4, 2023
Merged
larry-safran added a commit that referenced this issue Mar 6, 2023
@larry-safran
api:stabilize offloadExecutor. (#9931)
7aa5598 
* api:Stabalize offloadExecutor.

fixes #6279
@ejona86 ejona86 modified the milestones: Next, 1.54 Mar 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@larry-safran larry-safran

Labels
experimental API Issue tracks stabilizing an experimental API
Projects
None yet
Milestone
1.54
Development

Successfully merging a pull request may close this issue.

api:stabilize offloadExecutor. larry-safran/grpc-java
2 participants
@ejona86 @larry-safran