Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for proto3 field presence #7051

Closed
stanley-cheung opened this issue May 20, 2020 · 4 comments
Closed

Support for proto3 field presence #7051

stanley-cheung opened this issue May 20, 2020 · 4 comments
Assignees
@dapengzhang0
Labels
enhancement
Milestone
1.30

Comments

@stanley-cheung
Copy link
Contributor

Proto3 introduced the optional syntax to support field presence tracking in release 3.12.0. We need to add support in our grpc protoc plugin.

See this doc for more details. Basically we need to add a function GetSupportedFeatures() to our grpc protoc plugin to mark our compliance.

Please plan to do this in the next release. If not, please let me know. Thanks!
@stanley-cheung
Copy link
Contributor Author

FYI, grpc/grpc PR: grpc/grpc#22998

@dapengzhang0 dapengzhang0 added this to the 1.31 milestone May 20, 2020
@dapengzhang0 dapengzhang0 self-assigned this May 20, 2020
@dapengzhang0 dapengzhang0 mentioned this issue May 20, 2020
Merged
dapengzhang0 added a commit that referenced this issue May 20, 2020
@dapengzhang0
all: bump protobuf to 3.12.0
0d65467 
Version 3.12.0 is needed for the feature of support for proto3 field presence #7051
@dapengzhang0
Copy link
Member

Do we want the protoc flag --experimental_allow_proto3_optional on by default?

@dapengzhang0 dapengzhang0 mentioned this issue May 21, 2020
Merged
@stanley-cheung
Copy link
Contributor Author

Yes please turn it on by default. At first I thought the flag only applies to protoc. Looks like it applies to the plugin as well (i.e. will fail the plugin if .proto has the new syntax and the flag is not passed in)? Then yes we do want to turn on the flag by default. Thanks!

@dapengzhang0 dapengzhang0 mentioned this issue May 21, 2020
Closed
dapengzhang0 added a commit that referenced this issue May 21, 2020
@dapengzhang0
compiler: support proto3 field presence for codegen
97112b2 
Support proto3 field presence #7051.

This is the same change as https://github.com/grpc/grpc/pull/22998/files#diff-6c29ff8771ae54ddf2c14e2ef3eb554fR37-R44
dapengzhang0 added a commit to dapengzhang0/grpc-java that referenced this issue May 21, 2020
@dapengzhang0
all: bump protobuf to 3.12.0
cef914c 
Version 3.12.0 is needed for the feature of support for proto3 field presence grpc#7051
dapengzhang0 added a commit to dapengzhang0/grpc-java that referenced this issue May 21, 2020
@dapengzhang0
compiler: support proto3 field presence for codegen
0c6e090 
Support proto3 field presence grpc#7051.

This is the same change as https://github.com/grpc/grpc/pull/22998/files#diff-6c29ff8771ae54ddf2c14e2ef3eb554fR37-R44
@dapengzhang0 dapengzhang0 modified the milestones: 1.31, 1.30 May 21, 2020
dapengzhang0 added a commit that referenced this issue May 22, 2020
@dapengzhang0
all: bump protobuf to 3.12.0
b1487c1 
Version 3.12.0 is needed for the feature of support for proto3 field presence #7051
dapengzhang0 added a commit that referenced this issue May 22, 2020
@dapengzhang0
compiler: support proto3 field presence for codegen
bd1c256 
Support proto3 field presence #7051.

This is the same change as https://github.com/grpc/grpc/pull/22998/files#diff-6c29ff8771ae54ddf2c14e2ef3eb554fR37-R44
@dapengzhang0
Copy link
Member

Fixed by #7052 and #7054 . Backported to v1.30.x with #7058 .

dfawley pushed a commit to dfawley/grpc-java that referenced this issue Jan 15, 2021
@dapengzhang0 @dfawley
all: bump protobuf to 3.12.0
2cbaa3f 
Version 3.12.0 is needed for the feature of support for proto3 field presence grpc#7051
dfawley pushed a commit to dfawley/grpc-java that referenced this issue Jan 15, 2021
@dapengzhang0 @dfawley
compiler: support proto3 field presence for codegen
5ffb760 
Support proto3 field presence grpc#7051.

This is the same change as https://github.com/grpc/grpc/pull/22998/files#diff-6c29ff8771ae54ddf2c14e2ef3eb554fR37-R44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dapengzhang0 dapengzhang0

Labels
enhancement
Projects
None yet
Milestone
1.30
Development

No branches or pull requests
2 participants
@dapengzhang0 @stanley-cheung