Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the hack that generates nano package names. #900

Open
zhangkun83 opened this issue Aug 29, 2015 · 3 comments
Open

Remove the hack that generates nano package names. #900

zhangkun83 opened this issue Aug 29, 2015 · 3 comments
Milestone
Unscheduled

Comments

@zhangkun83
Copy link
Contributor

We should use a helper function from protobuf, which is more reliable, but not there yet (protocolbuffers/protobuf/issues/778)
@zhangkun83 zhangkun83 mentioned this issue Aug 29, 2015
Merged
@ejona86 ejona86 added this to the 1.0 milestone Dec 1, 2015
@ejona86 ejona86 modified the milestones: 1.1, 1.0 Apr 19, 2016
@zhangkun83
Copy link
Contributor Author

Still blocked by protocolbuffers/protobuf#778

@zhangkun83 zhangkun83 modified the milestones: Unscheduled, 1.1 Jan 12, 2017
@dapengzhang0
Copy link
Member

Is this obsolete?

@zhangkun83
Copy link
Contributor Author

No, the hack still exists in java_generator.cpp. Search for "issues/900" in the code.

@dapengzhang0 dapengzhang0 mentioned this issue Apr 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Unscheduled
Development

No branches or pull requests
3 participants
@ejona86 @dapengzhang0 @zhangkun83