Private ServerMethodDefinition constructor; avoid create() in codegen #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make |
|
LGTM |
Umm... Yeah. Done. I now do the thing I said I was doing. |
|
LGTM |
There is no need to use ServerMethodDefinition in codegen. The create() method itself could be helpful to a dynamic HandlerRegistry implementation, so we won't remove it.
ejona86
force-pushed
the
remove-methodef-create
branch
from
5d37165
to
a6621da
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to use ServerMethodDefinition in codegen. The create()
method itself could be helpful to a dynamic HandlerRegistry
implementation, so we won't remove it.
This has mostly no impact on our public API, so could be delayed after beta. But it
does fix a missing check in one of the addMethod() overloads, which could break
broken code if we added it later.