Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android,binder,cronet: .aar file when publishing #10138

Merged
merged 2 commits into from
May 5, 2023
Merged

android,binder,cronet: .aar file when publishing #10138

merged 2 commits into from
May 5, 2023

Conversation

temawi
Copy link
Contributor

@temawi temawi commented May 5, 2023 •
edited
Loading

The upgraded Android Gradle Plugin no longer played nice with the android-maven-publish plugin used earlier to produce Android library .aar files. No .aar files were being published at all.

This removes the android-maven-publish plugin that is no longer needed with the newer version of AGP and updates the grpc-android, grpc-binder and grpc-cronet to use the native Android library publishing features of AGP.

Using the grpc-android project as an example, before these changes the files produced by the publishing step were:

-rw-r--r--@ 1 tmwilson  wheel  287157 May  4 16:15 grpc-android-1.56.0-20230504.231500-1-javadoc.jar
-rw-r--r--@ 1 tmwilson  wheel      32 May  4 16:15 grpc-android-1.56.0-20230504.231500-1-javadoc.jar.md5
-rw-r--r--@ 1 tmwilson  wheel      40 May  4 16:15 grpc-android-1.56.0-20230504.231500-1-javadoc.jar.sha1
-rw-r--r--@ 1 tmwilson  wheel      64 May  4 16:15 grpc-android-1.56.0-20230504.231500-1-javadoc.jar.sha256
-rw-r--r--@ 1 tmwilson  wheel     128 May  4 16:15 grpc-android-1.56.0-20230504.231500-1-javadoc.jar.sha512
-rw-r--r--@ 1 tmwilson  wheel    8513 May  4 16:15 grpc-android-1.56.0-20230504.231500-1-sources.jar
-rw-r--r--@ 1 tmwilson  wheel      32 May  4 16:15 grpc-android-1.56.0-20230504.231500-1-sources.jar.md5
-rw-r--r--@ 1 tmwilson  wheel      40 May  4 16:15 grpc-android-1.56.0-20230504.231500-1-sources.jar.sha1
-rw-r--r--@ 1 tmwilson  wheel      64 May  4 16:15 grpc-android-1.56.0-20230504.231500-1-sources.jar.sha256
-rw-r--r--@ 1 tmwilson  wheel     128 May  4 16:15 grpc-android-1.56.0-20230504.231500-1-sources.jar.sha512
-rw-r--r--@ 1 tmwilson  wheel    1643 May  4 16:15 grpc-android-1.56.0-20230504.231500-1.pom
-rw-r--r--@ 1 tmwilson  wheel      32 May  4 16:15 grpc-android-1.56.0-20230504.231500-1.pom.md5
-rw-r--r--@ 1 tmwilson  wheel      40 May  4 16:15 grpc-android-1.56.0-20230504.231500-1.pom.sha1
-rw-r--r--@ 1 tmwilson  wheel      64 May  4 16:15 grpc-android-1.56.0-20230504.231500-1.pom.sha256
-rw-r--r--@ 1 tmwilson  wheel     128 May  4 16:15 grpc-android-1.56.0-20230504.231500-1.pom.sha512
-rw-r--r--@ 1 tmwilson  wheel    1028 May  4 16:15 maven-metadata.xml
-rw-r--r--@ 1 tmwilson  wheel      32 May  4 16:15 maven-metadata.xml.md5
-rw-r--r--@ 1 tmwilson  wheel      40 May  4 16:15 maven-metadata.xml.sha1
-rw-r--r--@ 1 tmwilson  wheel      64 May  4 16:15 maven-metadata.xml.sha256
-rw-r--r--@ 1 tmwilson  wheel     128 May  4 16:15 maven-metadata.xml.sha512

After the change get get:

-rw-r--r--@ 1 tmwilson  wheel  292629 May  5 11:32 grpc-android-1.56.0-20230505.183236-1-javadoc.jar
-rw-r--r--@ 1 tmwilson  wheel      32 May  5 11:32 grpc-android-1.56.0-20230505.183236-1-javadoc.jar.md5
-rw-r--r--@ 1 tmwilson  wheel      40 May  5 11:32 grpc-android-1.56.0-20230505.183236-1-javadoc.jar.sha1
-rw-r--r--@ 1 tmwilson  wheel      64 May  5 11:32 grpc-android-1.56.0-20230505.183236-1-javadoc.jar.sha256
-rw-r--r--@ 1 tmwilson  wheel     128 May  5 11:32 grpc-android-1.56.0-20230505.183236-1-javadoc.jar.sha512
-rw-r--r--@ 1 tmwilson  wheel    8843 May  5 11:32 grpc-android-1.56.0-20230505.183236-1-sources.jar
-rw-r--r--@ 1 tmwilson  wheel      32 May  5 11:32 grpc-android-1.56.0-20230505.183236-1-sources.jar.md5
-rw-r--r--@ 1 tmwilson  wheel      40 May  5 11:32 grpc-android-1.56.0-20230505.183236-1-sources.jar.sha1
-rw-r--r--@ 1 tmwilson  wheel      64 May  5 11:32 grpc-android-1.56.0-20230505.183236-1-sources.jar.sha256
-rw-r--r--@ 1 tmwilson  wheel     128 May  5 11:32 grpc-android-1.56.0-20230505.183236-1-sources.jar.sha512
-rw-r--r--@ 1 tmwilson  wheel   15933 May  5 11:32 grpc-android-1.56.0-20230505.183236-1.aar
-rw-r--r--@ 1 tmwilson  wheel      32 May  5 11:32 grpc-android-1.56.0-20230505.183236-1.aar.md5
-rw-r--r--@ 1 tmwilson  wheel      40 May  5 11:32 grpc-android-1.56.0-20230505.183236-1.aar.sha1
-rw-r--r--@ 1 tmwilson  wheel      64 May  5 11:32 grpc-android-1.56.0-20230505.183236-1.aar.sha256
-rw-r--r--@ 1 tmwilson  wheel     128 May  5 11:32 grpc-android-1.56.0-20230505.183236-1.aar.sha512
-rw-r--r--@ 1 tmwilson  wheel    1643 May  5 11:32 grpc-android-1.56.0-20230505.183236-1.pom
-rw-r--r--@ 1 tmwilson  wheel      32 May  5 11:32 grpc-android-1.56.0-20230505.183236-1.pom.md5
-rw-r--r--@ 1 tmwilson  wheel      40 May  5 11:32 grpc-android-1.56.0-20230505.183236-1.pom.sha1
-rw-r--r--@ 1 tmwilson  wheel      64 May  5 11:32 grpc-android-1.56.0-20230505.183236-1.pom.sha256
-rw-r--r--@ 1 tmwilson  wheel     128 May  5 11:32 grpc-android-1.56.0-20230505.183236-1.pom.sha512
-rw-r--r--@ 1 tmwilson  wheel    1202 May  5 11:32 maven-metadata.xml
-rw-r--r--@ 1 tmwilson  wheel      32 May  5 11:32 maven-metadata.xml.md5
-rw-r--r--@ 1 tmwilson  wheel      40 May  5 11:32 maven-metadata.xml.sha1
-rw-r--r--@ 1 tmwilson  wheel      64 May  5 11:32 maven-metadata.xml.sha256
-rw-r--r--@ 1 tmwilson  wheel     128 May  5 11:32 maven-metadata.xml.sha512

The diff output from comparing the old POM with the new is:

7c7
<   <packaging>pom</packaging>
---
>   <packaging>aar</packaging>

@temawi temawi marked this pull request as ready for review May 5, 2023 18:39
@temawi temawi requested a review from ejona86 May 5, 2023 18:39
ejona86
ejona86 approved these changes May 5, 2023
View reviewed changes
android/build.gradle Show resolved Hide resolved
@temawi temawi merged commit 0005029 into grpc:master May 5, 2023
6 checks passed
temawi added a commit to temawi/grpc-java that referenced this pull request May 5, 2023
@temawi
android,binder,cronet: .aar file when publishing (grpc#10138)
a896561
@temawi temawi mentioned this pull request May 5, 2023
Merged
temawi added a commit that referenced this pull request May 8, 2023
@temawi
android,binder,cronet: .aar file when publishing (#10138) (#10144)
0847e2b
@ejona86 ejona86 mentioned this pull request Jun 15, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@temawi @ejona86