okhttp: okhttp client and server transport should use padded length for flow control #10422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Jul 27, 2023
YifeiZhuang
force-pushed
the
fix-okhttp-pad-len
branch
from
139dabe
to
3f54bfd
Compare
YifeiZhuang
force-pushed
the
fix-okhttp-pad-len
branch
from
788a4b5
to
804d9a2
Compare
ejona86
reviewed
Aug 8, 2023
ejona86
reviewed
Aug 9, 2023
YifeiZhuang
force-pushed
the
fix-okhttp-pad-len
branch
from
540265c
to
6933356
Compare
YifeiZhuang
changed the title
YifeiZhuang
force-pushed
the
fix-okhttp-pad-len
branch
from
6933356
to
e4d26b5
Compare
YifeiZhuang
force-pushed
the
fix-okhttp-pad-len
branch
from
e4d26b5
to
5746ac3
Compare
ejona86
reviewed
Aug 14, 2023
| return createMessageFrame(stringMessage, 0); | ||
| } | ||
|
|
||
| private static Buffer createMessageFrame(String stringMessage, int paddingLength) { |
There was a problem hiding this comment.
I don't see the point of this new method, and it is a bit misleading. This seems to only work because nothing consumes the padding. When outside of the test, the buffer would have paddingLength-1 extra data, because 1 byte was consumed to communicate the padding length.
It seems this could just be removed and use the old non-padding-enabled creation.
okhttp/src/test/java/io/grpc/okhttp/OkHttpServerTransportTest.java
Outdated
Show resolved
Hide resolved
ejona86
approved these changes
Aug 16, 2023
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Aug 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #10018