Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locality logging #10423

Merged
merged 1 commit into from Aug 1, 2023
Merged

Fix locality logging #10423

merged 1 commit into from Aug 1, 2023

Conversation

halvards
Copy link
Contributor

The bootstrapping code currently does not log zone and subZone from locality correctly, and only logs region. This commit fixes the logging message format.

The bootstrapping code currently does not log zone and subZone from locality correctly, and only logs region. This commit fixes the logging message format.
Copy link
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: thanks for finding the issue!

@sanjaypujare sanjaypujare added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 27, 2023
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 27, 2023
@larry-safran larry-safran merged commit 4dc786b into grpc:master Aug 1, 2023
14 checks passed
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Aug 14, 2023
The bootstrapping code currently does not log zone and subZone from locality correctly, and only logs region. This commit fixes the logging message format.
@halvards halvards deleted the patch-1 branch September 18, 2023 05:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants