Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed assert for flakey static stride scheduler with multiple threads #10437

Merged
merged 8 commits into from
Jul 31, 2023
Merged

removed assert for flakey static stride scheduler with multiple threads #10437

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6540c29
static stride scheduler algorithm/class (currently unused)
tonyjongyoonan Jun 9, 2023
4354297
Merge pull request #2 from tonyjongyoonan/static-stride-scheduler-dra…
tonyjongyoonan Jun 12, 2023
13731d0
Revert "static stride scheduler algorithm/class (currently unused)"
tonyjongyoonan Jun 12, 2023
2d9dcf3
Merge pull request #3 from tonyjongyoonan/revert-2-static-stride-sche…
tonyjongyoonan Jun 12, 2023
9ea0ab3
Merge pull request #8 from grpc/master
tonyjongyoonan Jul 11, 2023
3d444a5
Merge branch 'grpc:master' into master
tonyjongyoonan Jul 12, 2023
cb86054
Merge branch 'grpc:master' into wrr-flakey-threads
tonyjongyoonan Jul 31, 2023
6469b6d
removed assert statement
tonyjongyoonan Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions xds/src/main/java/io/grpc/xds/WeightedRoundRobinLoadBalancer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,9 +431,7 @@ long getSequence() {
* an offset that varies per backend index is also included to the calculation.
*/
int pick() {
int i = 0;
while (true) {
i++;
long sequence = this.nextSequence();
int backendIndex = (int) (sequence % scaledWeights.length);
long generation = sequence / scaledWeights.length;
Expand All @@ -442,7 +440,6 @@ int pick() {
if ((weight * generation + offset) % K_MAX_WEIGHT < K_MAX_WEIGHT - weight) {
continue;
}
assert i <= scaledWeights.length : "scheduler has more than one pass through";
return backendIndex;
}
}
Expand Down