Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Android examples to use AGP 7.4.0 #10497

Merged
merged 3 commits into from Aug 17, 2023

Conversation

temawi
Copy link
Contributor

@temawi temawi commented Aug 16, 2023

Upgrades the Android examples to use Android Gradle Plugin 7.4.0.

Fixes #10445

@temawi temawi requested a review from ejona86 August 16, 2023 23:00
@ejona86
Copy link
Member

ejona86 commented Aug 16, 2023

I already tried "just change the version." It will not be so easy as that, though.

This allows the android.useAndroidX flag to be set which is now needed
by the examples.
@temawi
Copy link
Contributor Author

temawi commented Aug 17, 2023

I already tried "just change the version." It will not be so easy as that, though.

I was fooled by build and deploy working locally. It needed the appcompat library to be upgraded to AndroidX.

@temawi temawi merged commit beaeeef into grpc:master Aug 17, 2023
14 checks passed
@temawi temawi deleted the android_examples_agp740 branch August 17, 2023 18:24
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Aug 29, 2023
- Upgrades AGP version to 7.4.0
- Upgrades appcomat to use AndroidX
- Updates the `android.sh` build script to set the `android.useAndroidX` flag
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Android Examples to AGP 7.4.0
2 participants