Allow users outside of io.grpc.xds package to create custom xDS resources #10834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rces. Currently few of the interfaces needed to define and start a watch for a xDS resource are package private, which can't be used. Also move a exception definition in the XdsClientImpl into XdsResourceType, instead of exposing via the implementation package.
YifeiZhuang
reviewed
Jan 24, 2024
| @@ -38,7 +39,7 @@ | |||
| import java.util.Set; | |||
| import javax.annotation.Nullable; | |||
|
|
|||
| abstract class XdsResourceType<T extends ResourceUpdate> { | |||
| public abstract class XdsResourceType<T extends ResourceUpdate> { | |||
There was a problem hiding this comment.
annotate the class as @experimentalapi("issue link")
Then create an issue tracking "XdsResourceType is experimental"
YifeiZhuang
approved these changes
Jan 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently few of the interfaces needed to define and start a watch for a xDS resource are package private, which can't be used externally outside of io.grpc.xds. Exposing them outside allows users to define their own custom resources and start a watch along with the default supported resources.
Also as part of this change, move an Exception defined in the XdsClientImpl into XdsResourceType. As XdsClientImpl is an implementation package, it makes more sense to expose it via the XdsResourceType class.
cc: @ejona86 , @YifeiZhuang