Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: Stabilize CsdsService #11003

Merged
merged 1 commit into from Mar 11, 2024
Merged

xds: Stabilize CsdsService #11003

merged 1 commit into from Mar 11, 2024

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented Mar 11, 2024 •
edited

To make it stable, this PR hides protobuf from being exposed via the API.
Note: this breaks ABI of CsdsService.streamClientStatus and CsdsService.fetchClientStatus, but these methods should not normally be called by the user.

Closes #8016.

@sergiitk
Copy link
Member Author

sergiitk commented Mar 11, 2024 •
edited

URL Map tests adhoc run (relies on CSDS heavily):

@sergiitk sergiitk requested a review from ejona86 March 11, 2024 21:38
@sergiitk sergiitk merged commit 0d749c5 into grpc:master Mar 11, 2024
15 checks passed
@sergiitk sergiitk deleted the stabilize-csds branch March 11, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issue for io.grpc.xds.CsdsService being experimental
2 participants
@sergiitk @ejona86