Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: fix logging to be compatible with Android for AdvancedTlsX509KeyManager #11270

Conversation

danielzhaotongliu
Copy link
Contributor

@danielzhaotongliu danielzhaotongliu commented Jun 6, 2024

  • Previous java.util.logging.Logger#log() usage in AdvancedTlsX509KeyManager.java was newly introduced in API level 26 not backwards compatible with Android

Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is severe, we're not too concerned about it not actually logging. If we become concerned later, we'll just add the normal "if log level is on" check.

@ejona86
Copy link
Member

ejona86 commented Jun 6, 2024

CC @erm-g

@erm-g
Copy link
Contributor

erm-g commented Jun 7, 2024

  • Previous java.util.logging.Logger#log() usage in AdvancedTlsX509KeyManager.java was newly introduced in API level 26 not backwards compatible with Android

Thanks for catching this! Yeah I see that the method was added in 26 - https://developer.android.com/sdk/api_diff/26/changes/java.util.logging.Logger
Did you catch it using some tests that I missed to run?

@erm-g
Copy link
Contributor

erm-g commented Jun 7, 2024

CC @erm-g

I pushed the same for the TrustManager - #11216

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jun 7, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jun 7, 2024
@danielzhaotongliu
Copy link
Contributor Author

@erm-g this was caught as part of Error Prone with the gRPC import CL

@ejona86 ejona86 merged commit 4943b4c into grpc:master Jun 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants