Add instrumentation tags to opencensus metrics #11322
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two tags to the A66 metrics exported by the opencensus stats module. This will be picked up by the Cloud Monitoring pipeline and allow us to build dashboard off these tags. Similarly done in grpc-ecosystem/grpc-spring#1081
|
Where are these tags defined? Where's the design? |
Responded in DM |
ejona86
reviewed
Jul 10, 2024
| @@ -787,6 +799,8 @@ public ServerStreamTracer newServerStreamTracer(String fullMethodName, Metadata | |||
| tagger | |||
| .toBuilder(parentCtx) | |||
| .putLocal(RpcMeasureConstants.GRPC_SERVER_METHOD, methodTag) | |||
| .putLocal(INSTRUMENTATION_SOURCE, LIBRARY_NAME) | |||
There was a problem hiding this comment.
From the looks of it, we should just do something like this on client-side as well and not update the individual record sites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two tags to the A66 metrics exported by the opencensus stats module. This will be picked up by the Cloud Monitoring pipeline and allow us to build dashboard off these tags.
Similarly done in grpc-ecosystem/grpc-spring#1081