security: Add updateIdentityCredentials methods to AdvancedTlsX509KeyManager. #11358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param period the period between successive read-and-update executions | ||
| * @param unit the time unit of the initialDelay and period parameters | ||
| * @param executor the execute service we use to read and update the credentials | ||
| * @return an object that caller should close when the file refreshes are not needed | ||
| */ | ||
| public Closeable updateIdentityCredentialsFromFile(File keyFile, File certFile, | ||
| public Closeable updateIdentityCredentials(File certFile, File keyFile, |
There was a problem hiding this comment.
For my own understanding, why do we want to swap the order of the arguments?
There was a problem hiding this comment.
Resolving based on our offline conversation.
matthewstevenson88
approved these changes
Jul 9, 2024
kannanjgithub
approved these changes
Jul 9, 2024
ejona86
reviewed
Jul 10, 2024
| */ | ||
| @Deprecated | ||
| @InlineMe(replacement = "this.updateIdentityCredentials(certs, key)") |
There was a problem hiding this comment.
Add the ExperimentalApi annotation to the deprecated methods so it is clear they can be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new 'updateIdentityCredentials' methods with swapped (chain, key) arguments are added. Original 'updateIdentityCredentialsFromFiles' are deprecated.