Restore old behavior of NettyAdaptiveCumulator, but avoid using that class if Netty is on version 4.1.111 or later #11367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…class if Netty is on version 4.1.111 or later.
ejona86
approved these changes
Jul 10, 2024
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Jul 10, 2024
…class if Netty is on version 4.1.111 or later. (grpc#11367)
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Jul 10, 2024
…class if Netty is on version 4.1.111 or later. (grpc#11367)
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Jul 10, 2024
…class if Netty is on version 4.1.111 or later. (grpc#11367)
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix to support Netty 4.1.111 caused a problem in a Google internal test which led to #11366 which would have completely broken Netty 4.1.111 installations. This eliminates the problems that caused a desire to revert.
A long term fix should be developed to keep the performance advantages provided by NettyAdaptiveCumulator with no down sides.