Run createTransportRunnable outside of lock. #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `scheduleConnection()` is run under lock, if we ran `createTransportRunnable` inside `scheduleConnection()`, `savedDelayedTransport.setTransport()` will be under lock which violates the assumption made in grpc#1408 that > there is an implicit rule today that channel layer will not hold any lock while calling into transport and had caused deadlock with `InProcessTransport`. This is a partial back-port of 0e14516 from master. A large portion of changes on tests is not ported because of conflict caused by API changes in master.
|
@zhangkun83 LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
scheduleConnection()is run under lock, if we rancreateTransportRunnableinsidescheduleConnection(),savedDelayedTransport.setTransport()will be under lock which violatesthe assumption made in #1408 that
and had caused deadlock with
InProcessTransport.This is a partial back-port of 0e14516
from master. A large portion of changes on tests is not ported because
of conflict caused by API changes in master.