Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: ManagedChannelImpl2. #2530

Merged
merged 15 commits into from
Jan 9, 2017
Merged

core: ManagedChannelImpl2. #2530

merged 15 commits into from
Jan 9, 2017

Commits on Dec 16, 2016

  1. Fork ManagedChannelImpl and its tests.

    @zhangkun83
    zhangkun83 committed Dec 16, 2016
    Configuration menu
    Copy the full SHA
    a79f2c1 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2016

  1. core: ManagedChannelImpl2. 

    1. Adapt to LoadBalancer2 interface.  Channel holds on to a single
   DelayedClientTransport2.

2. Lock-free: every channel state mutation, including Subchannel
   mutations, calling into LoadBalancer, idleness and shutdown, is made
   from channelExecutor.

3. Idleness grace period is no longer needed.
    @zhangkun83
    zhangkun83 committed Dec 17, 2016
    Configuration menu
    Copy the full SHA
    850aefc View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2016

  1. Cosmetic and documentation fixes.

    @zhangkun83
    zhangkun83 committed Dec 20, 2016
    Configuration menu
    Copy the full SHA
    c0e1b2d View commit details
    Browse the repository at this point in the history

  2. Bug fix: OobChannel.shutdownNow() should set shutdown to true.

    @zhangkun83
    zhangkun83 committed Dec 20, 2016
    Configuration menu
    Copy the full SHA
    5225693 View commit details
    Browse the repository at this point in the history

  3. Bug fix: SubchannelImplImpl should schedule the timer within the lock.

    @zhangkun83
    zhangkun83 committed Dec 20, 2016
    Configuration menu
    Copy the full SHA
    0ae084e View commit details
    Browse the repository at this point in the history

  4. Remove unused field from test.

    @zhangkun83
    zhangkun83 committed Dec 20, 2016
    Configuration menu
    Copy the full SHA
    97c463b View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2016

  1. Switch to ObjectPool. 

    ObjectPool is simpler to use and more test-friendly than the raw
SharedResourceHolder.

Also assign ManagedChannel's executor to directExecutor after returning
the real executor to pool.
    @zhangkun83
    zhangkun83 committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    3bbe8c3 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2016

  1. Add tests for returning the shared executors.

    @zhangkun83
    zhangkun83 committed Dec 29, 2016
    Configuration menu
    Copy the full SHA
    014ffc2 View commit details
    Browse the repository at this point in the history

  2. Stop clearing app executor when channel is terminated.

    @zhangkun83
    zhangkun83 committed Dec 29, 2016
    Configuration menu
    Copy the full SHA
    108345e View commit details
    Browse the repository at this point in the history

  3. shutdown() doesn't need to call maybeTerminateChannel(); 

    Because it's handled by delayedTransport termination.
    @zhangkun83
    zhangkun83 committed Dec 29, 2016
    Configuration menu
    Copy the full SHA
    55c05f7 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2016

  1. Add a comment.

    @zhangkun83
    zhangkun83 committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    072b6c3 View commit details
    Browse the repository at this point in the history

  2. Prefer runSerialized() to channelExecutor.

    @zhangkun83
    zhangkun83 committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    c52ee3e View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2017

  1. Do not clear subchannels and oobchannels at shutdownNow.

    @zhangkun83
    zhangkun83 committed Jan 3, 2017
    Configuration menu
    Copy the full SHA
    60bc5a2 View commit details
    Browse the repository at this point in the history

  2. A few no-op changes.

    @zhangkun83
    zhangkun83 committed Jan 3, 2017
    Configuration menu
    Copy the full SHA
    68578f5 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2017

  1. Merge branch 'master' into lbv2_channel_review

    @zhangkun83
    zhangkun83 committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    72ad669 View commit details
    Browse the repository at this point in the history