compiler: support deprecated proto option

[elandau]

Honor protobuf's option deprecated = true; and include the @deprecated annotation on services and methods.

[thelinuxfoundation]

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

• User @elandau isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
CLA GitHub bot

[carl-mastrangelo]

LGTM

You probably need to regenerate the golden files after adding a dummy deprecated method.

[elandau]

Something funky is going on with getting the CLA signed. I'm not getting the validation email from https://identity.linuxfoundation.org/user/validate-email. Any suggestions on getting past this?

[carl-mastrangelo]

@elandau check your spam folder. We have contacted the CNCF but so far can't tell what's going on.

[elandau]

Trying to trigger rebuild for CLA

[thelinuxfoundation]

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

• User @elandau isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
CLA GitHub bot

[elandau]

Trying to trigger rebuild for CLA

[carl-mastrangelo]

Re poking jobs, @ejona86 want to take a second look?

[ejona86]

Windows is failing because of a newline issue. The new golden files should probably be marked as binary in git.

[ejona86]

There is the Windows newline thing to resolve. I think modifying .gitattributes is the way to do that.

[carl-mastrangelo]

@elandau would you be able to apply @ejona86 's comment to get the Windows build to pass?

[ejona86]

Thank you @elandau!