core: ProxiedSocketAddress on public API #5344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@idelvall, just a heads-up. This change may cause breakage in your work. |
ejona86
approved these changes
Feb 11, 2019
| */ | ||
| @ExperimentalApi("https://github.com/grpc/grpc-java/issues/5279") | ||
| public final class HttpConnectProxiedSocketAddress extends ProxiedSocketAddress { | ||
| private static final long serialVersionUID = 6815392291648496951L; |
There was a problem hiding this comment.
Feel free to just use 0 or 1 here. The "random" serialVersionUID is only necessary when adding serialVersionUID to pre-existing classes, as it needs to match what Java would have generated. For new classes, treating it as a "version number" is likely to be more clear.
|
Related: #5279 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine the public
ProxyParametersand the internalProxySocketAddressasHttpConnectProxiedSocketAddress. The more specific name signifies the type of the proxy we currently support, and makes room for other proxy types (e.g., SOCKS) in the future. The combination simplifies NameResolver implementation.Introduce
ProxiedSocketAddressas the base class that is returned byProxyDetector, mainly for clarification and documentation. Added documentation about proxy in general onProxyDetector.