core: Add NameResolverRegistry #5586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
approved these changes
Apr 13, 2019
zhangkun83
reviewed
Apr 19, 2019
zhangkun83
approved these changes
Apr 19, 2019
NameResolverRegistry takes on all the logic previously in NameResolverProvider. But it also allows manual registration of NameResolvers, which is useful when the providers have complex construction or need objects injected into them. This also avoids a circular dependency during class loading since previously loading any Provider searched for all Providers via ClassLoader since ClassLoader handling was static within the parent class. Fixes grpc#5562
ejona86
force-pushed
the
name-resolver-registry
branch
from
eaf5a48
to
7cf6df3
Compare
|
Rebased past grpc-api creation |
ST-DDT
approved these changes
Apr 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NameResolverRegistry takes on all the logic previously in
NameResolverProvider. But it also allows manual registration of
NameResolvers, which is useful when the providers have complex
construction or need objects injected into them.
This also avoids a circular dependency during class loading since
previously loading any Provider searched for all Providers via
ClassLoader since ClassLoader handling was static within the parent
class.
Fixes #5562
CC @ST-DDT