-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding s390x support to grpc-java #6152
Conversation
@ejona86 Why CLA checker isn't showing up? |
@dapengzhang0, good question... I had hoped closing and reopening would fix it, but it didn't. Since it is a service I also can't see if the webhooks are being delivered. I'm pinging some people. |
We're checking on the status. Cc @jpalmerLinuxFoundation |
We identified the issue with the EasyCLA application processing this specific PR request. We are working on a solution. |
A bug has apparently been fixed in EasyCLA, but I think we will need to wait until Wednesday for a new release to be deployed. |
@ejona86 Please let me know when this PR gets merged |
Fix not yet deployed to production |
User To test/validate, run: |
@dealako |
@ejona86, I could be mistaken, but the GitHub commit says
which reveals:
and when I attempt to lookup snalkar in GitHub, it says not found. |
Regardless, I'm going to introduce a workaround in EasyCLA as we were relying on GitHub to acquire the user's GH id. |
@dealako, the commit uses an email address. My commits use |
@dealako, I think you are barking up the wrong tree. For example, consider my PR #6224
And yet the easycla status was correct on the PR. That author and committer name is the "name" of the author in normal email form. In the commit it has |
@ejona86 thanks for the helpful feedback - I'm working on the logic that matches the commit author details, what we can additionally lookup/match from GitHub, and what matches the EasyCLA signature records. We did have an issue when looking up a GitHub user by grabbing the commit author Edit: author name -> author details |
The commit author name is useless for easycla. It is an arbitrary string. It can be helpful to humans reading it, but it is useless for a machine. |
|
It looks like the check ran, thanks @dealako |
@Nayana-ibm, the CLA bot is now working. Go ahead and go through the process. |
Raised #6241 with correct commit user |
Adding support for s390x .
Please review