Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding s390x support to grpc-java #6152

Closed
wants to merge 0 commits into from

Conversation

Nayana-ibm
Copy link
Contributor

Adding support for s390x .
Please review

@ran-su ran-su requested a review from ejona86 September 13, 2019 17:06
@dapengzhang0
Copy link
Member

@ejona86 Why CLA checker isn't showing up?

@ejona86 ejona86 closed this Sep 13, 2019
@ejona86 ejona86 reopened this Sep 13, 2019
@ejona86
Copy link
Member

ejona86 commented Sep 13, 2019

@dapengzhang0, good question... I had hoped closing and reopening would fix it, but it didn't. Since it is a service I also can't see if the webhooks are being delivered. I'm pinging some people.

@dankohn
Copy link

dankohn commented Sep 14, 2019

We're checking on the status. Cc @jpalmerLinuxFoundation

@jpalmerLinuxFoundation
Copy link

@ejona86 Why CLA checker isn't showing up?

Can I get access to review the settings on the integrations tab? @ejona86

@dealako
Copy link

dealako commented Sep 14, 2019

We identified the issue with the EasyCLA application processing this specific PR request. We are working on a solution.

@ejona86
Copy link
Member

ejona86 commented Sep 17, 2019

A bug has apparently been fixed in EasyCLA, but I think we will need to wait until Wednesday for a new release to be deployed.

@Nayana-ibm
Copy link
Contributor Author

@ejona86 Please let me know when this PR gets merged

@ejona86 ejona86 closed this Sep 19, 2019
@ejona86 ejona86 reopened this Sep 19, 2019
@jpalmerLinuxFoundation
Copy link

Fix not yet deployed to production

@dealako
Copy link

dealako commented Oct 2, 2019

User snalkar doesn't appear to be a valid GitHub user. Was this user removed/deleted after the commit and PR were submitted? EasyCLA was unable to lookup this user ID within GitHub.

To test/validate, run:
curl -s -XGET https://api.github.com/users/snalkar

@ejona86
Copy link
Member

ejona86 commented Oct 2, 2019

@dealako snalkar isn't the github user. Nayana-ibm is the github user.

@dealako
Copy link

dealako commented Oct 2, 2019

@ejona86, I could be mistaken, but the GitHub commit says snalkar:

curl -s -XGET https://api.github.com/repos/grpc/grpc-java/git/commits/61e32c618940853d552ff62d041fc8fc5f755fe7

which reveals:

{
  ...
  "author": {
    "name": "snalkar",
    "email": "snalkar@us.ibm.com",
    "date": "2019-09-13T08:36:56Z"
  },
  "committer": {
    "name": "snalkar",
    "email": "snalkar@us.ibm.com",
    "date": "2019-09-13T08:36:56Z"
  },
  ...

and when I attempt to lookup snalkar in GitHub, it says not found.

@Nayana-ibm
Copy link
Contributor Author

Nayana-ibm commented Oct 2, 2019

@dealako @ejona86 Github commit also needs to be done by github user Nayana-ibm?

@dealako
Copy link

dealako commented Oct 2, 2019

Regardless, I'm going to introduce a workaround in EasyCLA as we were relying on GitHub to acquire the user's GH id.

@ejona86
Copy link
Member

ejona86 commented Oct 2, 2019

@dealako, the commit uses an email address. My commits use ejona@google.com for example, but my github id is ejona86. And that works fine. This would be the case ~100% of the time.

@ejona86
Copy link
Member

ejona86 commented Oct 2, 2019

@dealako, I think you are barking up the wrong tree. For example, consider my PR #6224

$ curl -s -XGET https://api.github.com/repos/grpc/grpc-java/git/commits/c5c7755d3fe9d84ec2d87e277a49ea15a3e9cba6
...
  "author": {
    "name": "Eric Anderson",
    "email": "ejona@google.com",
    "date": "2019-10-01T16:03:43Z"
  },
  "committer": {
    "name": "Eric Anderson",
    "email": "ejona@google.com",
    "date": "2019-10-01T19:57:08Z"
  },
...

And yet the easycla status was correct on the PR. That author and committer name is the "name" of the author in normal email form. In the commit it has Eric Anderson <ejona@google.com>.

@dealako
Copy link

dealako commented Oct 2, 2019

@ejona86 thanks for the helpful feedback - I'm working on the logic that matches the commit author details, what we can additionally lookup/match from GitHub, and what matches the EasyCLA signature records. We did have an issue when looking up a GitHub user by grabbing the commit author name details (id, public email) using the resulting GitHub numeric ID from their profile details, and using that for our initial EasyCLA search.

Edit: author name -> author details

@ejona86
Copy link
Member

ejona86 commented Oct 2, 2019

grabbing the commit author name

The commit author name is useless for easycla. It is an arbitrary string. It can be helpful to humans reading it, but it is useless for a machine.

@linux-foundation-easycla
Copy link

CLA Check
One or more committers are not authorized under a signed CLA as indicated below. Please click here to be authorized.

@jpalmerLinuxFoundation
Copy link

It looks like the check ran, thanks @dealako

@ejona86
Copy link
Member

ejona86 commented Oct 2, 2019

@Nayana-ibm, the CLA bot is now working. Go ahead and go through the process.

@Nayana-ibm
Copy link
Contributor Author

Raised #6241 with correct commit user

@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants