Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netty: Check for TE header after checking Content-Type #6194

Merged
merged 1 commit into from
Sep 25, 2019
Merged

netty: Check for TE header after checking Content-Type #6194

merged 1 commit into from
Sep 25, 2019

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Sep 25, 2019

Checking too early leads to false-positives, like if a non-gRPC client
contacts the server or a grpc-web client.

@ejona86
netty: Check for TE header after checking Content-Type
006ee3b 
Checking too early leads to false-positives, like if a non-gRPC client
contacts the server or a grpc-web client.
creamsoup
creamsoup approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@creamsoup creamsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejona86 ejona86 merged commit bd48891 into grpc:master Sep 25, 2019
@ejona86 ejona86 deleted the check-te-after-content-type branch September 25, 2019 21:04
@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@creamsoup creamsoup creamsoup approved these changes

Assignees

@creamsoup creamsoup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ejona86 @creamsoup