Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpclb: add child_policy_config_target_field_name to grpclb config #6563

Merged
merged 13 commits into from
Feb 11, 2020
Merged

grpclb: add child_policy_config_target_field_name to grpclb config #6563

merged 13 commits into from
Feb 11, 2020

Conversation

creamsoup
Copy link
Contributor

@creamsoup creamsoup commented Dec 20, 2019 •
edited

No description provided.

@creamsoup creamsoup marked this pull request as ready for review December 26, 2019 23:06
@creamsoup
Copy link
Contributor Author

config parsing behavior changes:

  • if childPolicy has only unknown policies, it will return Error (previously ROUND_ROBIN).
  • instead of only using the 1st child policy, it looks until it sees known policy.

see GrpclbLoadBalancerProviderTestas examples.

ejona86
ejona86 reviewed Feb 11, 2020
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I guess you're now expecting me to be the reviewer of this since Kun is OOO.

grpclb/src/main/java/io/grpc/grpclb/GrpclbLoadBalancerProvider.java Outdated Show resolved Hide resolved
@creamsoup creamsoup merged commit 774f276 into grpc:master Feb 11, 2020
@creamsoup creamsoup deleted the grpclb_target_name branch February 11, 2020 18:27
@ejona86 ejona86 mentioned this pull request Mar 23, 2020
Closed
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zhangkun83 zhangkun83 zhangkun83 left review comments

@ejona86 ejona86 ejona86 approved these changes

Assignees

@zhangkun83 zhangkun83

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@creamsoup @ejona86 @zhangkun83