Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: fix lint warnings #6658

Merged
merged 2 commits into from
Jan 30, 2020
Merged

all: fix lint warnings #6658

merged 2 commits into from
Jan 30, 2020

Conversation

creamsoup
Copy link
Contributor

No description provided.

voidzcy
voidzcy approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@voidzcy voidzcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, can you add a final to

grpc-java/xds/src/main/java/io/grpc/xds/XdsClientImpl.java

Line 1381 in 4ad3acb

static class MessagePrinter {
? Just forgot it.

@creamsoup creamsoup merged commit 2acca6e into grpc:master Jan 30, 2020
@creamsoup creamsoup deleted the lint2 branch January 30, 2020 18:00
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@voidzcy voidzcy voidzcy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@creamsoup @voidzcy