xds: no longer use existing Subchannels after xDS resource becomes unavailable #7081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esource becomes unavailable.
dapengzhang0
reviewed
Jun 2, 2020
| "Resource " + resourceName + " is unavailable"))); | ||
| if (edsBalancer != null) { | ||
| edsBalancer.shutdown(); | ||
| edsBalancer = null; |
There was a problem hiding this comment.
Need change the comment of the edsBalancer field.
There was a problem hiding this comment.
Removed that comment.
…not exist. When the resource is added back, it will be recreated.
dapengzhang0
approved these changes
Jun 3, 2020
voidzcy
added a commit
to voidzcy/grpc-java
that referenced
this pull request
Jun 3, 2020
…available (grpc#7081) Put Channel into TRANSIENT_FAILURE when CDS/EDS resource that is currently being watched becomes unavailable. CDS/EDS LB policies should shut down their downstream policy instances (stop using current Subchannels for new RPCs) and propagate TRANSIENT_FAILURE status to their parent policies (and may eventually to the Channel).
voidzcy
added a commit
to voidzcy/grpc-java
that referenced
this pull request
Jun 3, 2020
…available (grpc#7081) Put Channel into TRANSIENT_FAILURE when CDS/EDS resource that is currently being watched becomes unavailable. CDS/EDS LB policies should shut down their downstream policy instances (stop using current Subchannels for new RPCs) and propagate TRANSIENT_FAILURE status to their parent policies (and may eventually to the Channel).
voidzcy
added a commit
that referenced
this pull request
Jun 3, 2020
…available (backport v1.30x) (#7081) (#7087) Put Channel into TRANSIENT_FAILURE when CDS/EDS resource that is currently being watched becomes unavailable. CDS/EDS LB policies should shut down their downstream policy instances (stop using current Subchannels for new RPCs) and propagate TRANSIENT_FAILURE status to their parent policies (and may eventually to the Channel).
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
…available (grpc#7081) Put Channel into TRANSIENT_FAILURE when CDS/EDS resource that is currently being watched becomes unavailable. CDS/EDS LB policies should shut down their downstream policy instances (stop using current Subchannels for new RPCs) and propagate TRANSIENT_FAILURE status to their parent policies (and may eventually to the Channel).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put Channel into TRANSIENT_FAILURE when CDS/EDS resource that is currently being watched becomes unavailable.
LocalityStore.reset()works similar to shutting down downstream balancers and doing cleanup. Whether or not stop load reporting for current {cluster:eds_service} (note EDS resource =if eds_service != null then eds_service else cluster) is an open question. In this change, it will be stopped.EdsLoadBalanceris sort of messy, largely because we are also trying to maintain the functionality of it being working alone (although the internal interop tests for real use cases had been deleted). It might get cleaner after we eliminateLocalityStore.