Upgrade to Mockito 3.3.3 #7282
Merged
Upgrade to Mockito 3.3.3 #7282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verifyZeroInteractions has the same behavior as verifyNoMoreInteractions. It was deprecated in Mockito 3.0.1 and replaced with verifyNoInteractions, which does not change behavior depending on previous verify() calls. All instances were replaced with verifyNoInteractions, except those in ApplicationThreadDeframerTest which were replaced with verifyNoMoreInteractions since there is a verify() call in `@Before`.
|
CC @zhangkun83 |
dapengzhang0
approved these changes
Aug 6, 2020
This was referenced Aug 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verifyZeroInteractions has the same behavior as verifyNoMoreInteractions. It
was deprecated in Mockito 3.0.1 and replaced with verifyNoInteractions, which
does not change behavior depending on previous verify() calls. All instances
were replaced with verifyNoInteractions, except those in
ApplicationThreadDeframerTest which were replaced with verifyNoMoreInteractions
since there is a verify() call in
@Before.3.3.3 was chosen as that is the last version that matches the internal mockito version. The internal linter was complaining about verifyZeroInteractions being deprecated.