xds: not to use insecure DSA crypto #7347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although DSA is only used in tests so it's totally no security concern, it's annoying we need some workaround for internal checks to import. So removing the usage.
| } | ||
| } | ||
| } | ||
| return KeyFactory.getInstance("RSA").generatePrivate(spec); |
There was a problem hiding this comment.
My suggestion was to only remove the "DSA" case if that was the offending line. So something like:
try {
return KeyFactory.getInstance("RSA").generatePrivate(spec);
} catch (InvalidKeySpecException ignore) {
try {
return KeyFactory.getInstance("EC").generatePrivate(spec);
} catch (InvalidKeySpecException ignore2) {
throw new InvalidKeySpecException("Neither RSA, nor EC worked", e);
}
}
But if "EC" is also going to cause problems I am okay with this change. Could you confirm?
There was a problem hiding this comment.
EC is not disallowed. I also removed EC because you said "it might be okay to remove both DSA and EC since none of the tests is using those AFAIK" So we can delete unused code, if we do have EC case later we can add it back.
There was a problem hiding this comment.
Yes, I remember saying that but I was thinking we just make the minimal change necessary to unblock the import. Anyway we can add "EC" back if we ever need it (doubtful).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although DSA is only used in tests so it's totally no security concern, it's annoying we need some workaround for internal checks to import. So removing the usage.