Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: delete XdsClientImpl2 #7565

Merged
merged 1 commit into from
Oct 29, 2020
Merged

xds: delete XdsClientImpl2 #7565

merged 1 commit into from
Oct 29, 2020

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Oct 28, 2020 •
edited

XdsClientImpl2 ---> ClientXdsClient for client side and ServerXdsClient for server side.
XdsClientImplTest2 ---> ClientXdsClientTest
XdsClientImplTest2V2 ---> ClientXdsClientTestV2
XdsClientImplTestForListener ---> ServerXdsClientTest

@voidzcy
Delete XdsClientImpl2 and its tests. Client codepath has been migrate…
fbfd837 
…d to use ClientXdsClient and server codepath has been migrated to use ServerXdsClient.
sanjaypujare
sanjaypujare approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@voidzcy voidzcy merged commit 59528d8 into grpc:master Oct 29, 2020
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@voidzcy @dfawley
xds: delete XdsClientImpl2 (grpc#7565)
9988e24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dapengzhang0 dapengzhang0 dapengzhang0 approved these changes

@sanjaypujare sanjaypujare sanjaypujare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@voidzcy @dapengzhang0 @sanjaypujare