Remove Trailers #807
Merged
Remove Trailers #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Concrete instance for metadata attached to the end of the call. Only provided by | ||
| * servers. | ||
| */ | ||
| public static class Trailers extends Metadata { |
There was a problem hiding this comment.
Could we leave this class present but marked as @ Deprecated?
There was a problem hiding this comment.
Like just this class, keep the rest of the PR?
There was a problem hiding this comment.
Yeah. We could remove the byte[] constructor and the toString() without issue, but the public constructor is the main thing that existing code would be using.
|
@carl-mastrangelo LGTM |
carl-mastrangelo
force-pushed
the
trailers
branch
from
a1ec376
to
572f433
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headers will be removed next, this is only part 1.