GoogleAuthLibraryCallCredentialsTest to allow both old and new behavior from google-auth-library-java #8099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-auth-library-java:0.25.0 strips port and path parts in the
audience claim ("aud"). Updating the test to pass in both old
and new version of google-auth-library-java.
This commit does not upgrade google-auth-library-java because
it turned out that the upgrade involves the newer Guava version
(google-auth-library-java's dependency) failing with DexingNoClasspathTransform.
Details: grpc#8078 (comment)
It's technically possible to exclude the newer Guava, but it's a
good practice avoid excluding the newer version of a library.
suztomo
force-pushed
the
auth-test-update
branch
from
a0f2f71
to
41fd90e
Compare
suztomo
changed the title
ejona86
approved these changes
Apr 16, 2021
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
dapengzhang0
approved these changes
Apr 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8037 .
@ejona86 As discussed, this PR only updates the test. I cherry-picked your commit and added commit message on why we didn't upgrade the library for now.