Skip io.grpc.internal in javadoc. #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,6 +55,7 @@ javadoc { | |||
| source subproject.javadoc.source | |||
| options.links subproject.javadoc.options.links.toArray(new String[0]) | |||
| } | |||
| exclude 'io/grpc/internal/**' | |||
There was a problem hiding this comment.
Do we want to do this for core/build.gradle as well? I'm uncertain, but I think probably so since IDEs will probably being using that set of javadoc.
|
LGTM |
1 similar comment
|
LGTM |
|
@zhangkun83 LGTM |
Also move ExperimentalApi and Internal to io.grpc, so that they appear in javadoc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move ExperimentalApi and Internal to io.grpc, so that they appear
in javadoc.
Resolves #802