Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync branch android to head. #835

Merged
merged 7 commits into from Aug 19, 2015
Merged

Sync branch android to head. #835

merged 7 commits into from Aug 19, 2015

Conversation

madongfly
Copy link
Contributor

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@madongfly
Copy link
Contributor Author

@ejona86 @zsurocking, just sync, no any additional change, waiting for a LGTM.

@zsurocking
Copy link
Contributor

LGTM

@madongfly madongfly merged commit 7dbca92 into grpc:android Aug 19, 2015
@madongfly madongfly deleted the android branch August 19, 2015 22:54
@ejona86
Copy link
Member

ejona86 commented Aug 19, 2015

Does the android branch still need to be a fork? I seem to remember we cherry-picked some fixes, but if we are syncing to HEAD those should already be included.

@madongfly
Copy link
Contributor Author

This was done per @zsurocking's request, @zsurocking, could you comment on @ejona86's question.

@ejona86
Copy link
Member

ejona86 commented Aug 20, 2015

nm... This PR displays differently than I thought it did before. It isn't forked right now, so everything looks fine.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants