Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netty: Don't use old-style classpath for shadow plugin #8420

Merged
merged 1 commit into from Aug 18, 2021

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Aug 18, 2021

Seems it was introduced unnecessarily in dc74a31. This also removes the
jcenter reference which is a repository that no longer receives updates.


I noticed this when looking at upgrading the android plugin (because of the jcenter usage).

CC nastra

Seems it was introduced unnecessarily in dc74a31. This also removes the
jcenter reference which is a repository that no longer receives updates.
@ejona86
Copy link
Member Author

ejona86 commented Aug 18, 2021

CC @nastra

Copy link

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejona86
Copy link
Member Author

ejona86 commented Aug 18, 2021

@Nestra, concerning your deleted comment, it seems shadow would work fine for our build with newer versions of Gradle because we depend on maven plugin. It seems this was the only incompatibility: johnrengelman/shadow#624

@nastra
Copy link

nastra commented Aug 18, 2021

@Nestra, concerning your deleted comment, it seems shadow would work fine for our build with newer versions of Gradle because we depend on maven plugin. It seems this was the only incompatibility: johnrengelman/shadow#624

Ah that would make sense why the plugin worked. I ran into issues when upgrading to Gradle 7 with the shadow plugin in Apache Iceberg (apache/iceberg#2826, more specifically this line: https://github.com/apache/iceberg/pull/2826/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R27), that's why I upgraded the plugin here as well.

I think we should probably still upgrade the shadow plugin from 6.1 to 7.0 in #8388 so that nobody runs into issues in the future in case the maven plugin is ever removed, wdyt?

@ejona86
Copy link
Member Author

ejona86 commented Aug 18, 2021

I think we should probably still upgrade the shadow plugin from 6.1 to 7.0 in #8388 so that nobody runs into issues in the future in case the maven plugin is ever removed, wdyt?

I agree.

@ejona86 ejona86 merged commit 8026ccd into grpc:master Aug 18, 2021
@ejona86 ejona86 deleted the shadow-no-classpath branch August 18, 2021 17:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants