Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document equals and hashCode on Status #878

Closed
wants to merge 0 commits into from
Closed

Document equals and hashCode on Status #878

wants to merge 0 commits into from

Conversation

carl-mastrangelo
Copy link
Contributor

Resolves #751

nmittler
nmittler reviewed Aug 26, 2015
View reviewed changes
core/src/main/java/io/grpc/Status.java
}

/**
* Hash Codes on Statuses is not well defined.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: *are not well defined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. (also I'm dumb)

@nmittler
Copy link
Member

LGTM

1 similar comment
@zhangkun83
Copy link
Contributor

LGTM

@nmittler
Copy link
Member

Hash Codes on Statuses is not well defined.

The 'is' refers to equality which is singular.

"Equality" does not appear in that sentence. The "is" refers to "Hash Codes", which is plural. Not worth changing.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@zhangkun83 zhangkun83

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carl-mastrangelo @nmittler @zhangkun83