xds: Rename parseCluster() back to processCluster() for consistency #8802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to keep names of the top-level process* functions called from
handle*Response functions, and returning *Update resources consistent:
- `handleLdsResponse()` -> `LdsUpdate processClientSideListener()`
`LdsUpdate processServerSideListener()`
- `handleCdsResponse()` -> `CdsUpdate processCluster()`
- `handleRdsResponse()` -> `RdsUpdate processRouteConfiguration()`
- `handleEdsResponse()` -> `EdsUpdate processClusterLoadAssignment()`
For some reason, processCluster() was renamed to parseCluster() in
fa4b980.
sergiitk
force-pushed
the
xds-process-cluster-rename
branch
from
01b51ad
to
21f2acf
Compare
sergiitk
added
the
kokoro:force-run
grpc-kokoro
removed
the
kokoro:force-run
dapengzhang0
approved these changes
Jan 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to keep names of the top-level process* functions called from
handle*Response functions, and returning *Update resources consistent:
handleLdsResponse()->LdsUpdate processClientSideListener()LdsUpdate processServerSideListener()handleCdsResponse()->CdsUpdate processCluster()handleRdsResponse()->RdsUpdate processRouteConfiguration()handleEdsResponse()->EdsUpdate processClusterLoadAssignment()For some reason, processCluster() was renamed to parseCluster() in
fa4b980 / PR #8237.