xds: Don't end status with '.' in XdsNameResolver #8958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a45524 introduced '.' to the end of some status descriptions. We typically don't end status descriptiosn in periods, but that's minor. In this case though if the causal status ends in period then the new status will end in two periods, which could easily be confusing to users.
YifeiZhuang
approved these changes
Mar 2, 2022
YifeiZhuang
pushed a commit
to YifeiZhuang/grpc-java
that referenced
this pull request
Mar 4, 2022
2a45524 introduced '.' to the end of some status descriptions. We typically don't end status descriptiosn in periods, but that's minor. In this case though if the causal status ends in period then the new status will end in two periods, which could easily be confusing to users.
This was referenced Mar 4, 2022
YifeiZhuang
added a commit
that referenced
this pull request
Mar 8, 2022
2a45524 introduced '.' to the end of some status descriptions. We typically don't end status descriptiosn in periods, but that's minor. In this case though if the causal status ends in period then the new status will end in two periods, which could easily be confusing to users. Co-authored-by: Eric Anderson <ejona@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2a45524 introduced '.' to the end of some status descriptions. We
typically don't end status descriptiosn in periods, but that's minor. In
this case though if the causal status ends in period then the new status
will end in two periods, which could easily be confusing to users.