Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observability: integrate globalTags and configuration into rest of observability #9000

Merged
merged 4 commits into from
Mar 21, 2022

Conversation

sanjaypujare
Copy link
Contributor

wire observabilityConfig and globalTags into Observability and make
these available to the channel and server interceptors and specifially
to the LogHelper

CC @DNVindhya

…servability

wire observabilityConfig and globalTags into Observability and make
these available to the channel and server interceptors and specifially
to the LogHelper
Copy link
Contributor

@temawi temawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had one tweak suggestion.

@sanjaypujare sanjaypujare merged commit 2d7302d into grpc:master Mar 21, 2022
@sanjaypujare sanjaypujare deleted the integrate branch March 21, 2022 23:05
temawi pushed a commit to temawi/grpc-java that referenced this pull request Apr 8, 2022
…servability (grpc#9000)

* observability: integrate globalTags and configuration into rest of observability
wire observabilityConfig and globalTags into Observability and make
these available to the channel and server interceptors and specifically
to the LogHelper. Also separate globalTags into custom-tags and location-tags as required by the log-helper
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants