Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usage of ErrorProne CheckReturnValue #9126

Merged
merged 1 commit into from Apr 28, 2022
Merged

usage of ErrorProne CheckReturnValue #9126

merged 1 commit into from Apr 28, 2022

Conversation

marvinliu
Copy link
Contributor

Prefer ErrorProne's CheckReturnValue over JSR305's based on go/bugpattern/UsingJsr305CheckReturnValue

ejona86
ejona86 approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://errorprone.info/bugpattern/UsingJsr305CheckReturnValue is the public documentation for the same.

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 28, 2022
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 28, 2022
@ejona86 ejona86 mentioned this pull request Apr 28, 2022
Merged
@ejona86 ejona86 merged commit 40973ae into grpc:master Apr 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marvinliu @ejona86 @grpc-kokoro