Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security Policy for verifying signature using sha-256 hash #9305

Merged
merged 13 commits into from Jun 24, 2022
Merged

Add security Policy for verifying signature using sha-256 hash #9305

merged 13 commits into from Jun 24, 2022

Conversation

lllu30
Copy link
Contributor

@lllu30 lllu30 commented Jun 21, 2022

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 21, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@markb74 markb74 self-requested a review June 22, 2022 18:21
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jun 22, 2022
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jun 22, 2022
@markb74 markb74 requested a review from ejona86 June 23, 2022 09:19
markb74
markb74 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@markb74 markb74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good. I'm adding Eric as well to make sure I'm not missing anything wrt the Hashing class.

binder/src/main/java/io/grpc/binder/SecurityPolicies.java Outdated Show resolved Hide resolved
binder/src/main/java/io/grpc/binder/SecurityPolicies.java Outdated Show resolved Hide resolved
lllu30 and others added 6 commits June 23, 2022 17:42
@lllu30
function > predicate in doc comment
ef69d45
@lllu30
Merge pull request #3 from lllu30/sha256
c2362dd 
function > predicate in doc comment
@lllu30
change colletion to list
7174b91
@lllu30
Merge pull request #4 from lllu30/sha256
cc889bf 
change colletion to list
@lllu30
revert last change: collection > list, change immutablelist to list a…
64600cc 
…nd copy list to immutablelist
@lllu30
Merge pull request #5 from lllu30/sha256
3ab3274 
revert last change: collection > list, change immutable list to list and make copy of list.
@lllu30 lllu30 requested a review from ejona86 June 23, 2022 21:53
ejona86
ejona86 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the byte[]s get copied, then LGTM

binder/src/main/java/io/grpc/binder/SecurityPolicies.java Show resolved Hide resolved
@lllu30 lllu30 closed this Jun 23, 2022
@lllu30
Copy link
Contributor Author

lllu30 commented Jun 23, 2022

If the byte[]s get copied, then LGTM

deep copied byte[]s in latest commit.

@lllu30 lllu30 reopened this Jun 23, 2022
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jun 24, 2022
@grpc-kokoro grpc-kokoro removed kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run labels Jun 24, 2022
@ejona86 ejona86 merged commit 6193d20 into grpc:master Jun 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markb74 markb74 markb74 approved these changes

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lllu30 @ejona86 @markb74 @grpc-kokoro