Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump protobuf to 3.21.1 #9311

Merged
merged 6 commits into from
Jun 30, 2022
Merged

Bump protobuf to 3.21.1 #9311

merged 6 commits into from
Jun 30, 2022

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Jun 24, 2022

Fixes #9264

@ejona86 ejona86 requested a review from sergiitk June 24, 2022 15:10
@sergiitk
Copy link
Member

Looks like the build's still broken.

@ejona86
Copy link
Member Author

ejona86 commented Jun 24, 2022

It was a conflict due to Terry's recent Netty upgrade. I had done a push real quick before a meeting hoping Linux would be passing. I know Windows should still be failing due to a build change in Protobuf.

@sergiitk
Copy link
Member

Restarted java 11 build - it was running out of memory.

@ejona86
Copy link
Member Author

ejona86 commented Jun 24, 2022

protocolbuffers/protobuf#10174 I'm not sure how we'll want to react to the build bug.

This should fix the build, but I don't see any warning about it being
deprecated in the logs. Looks like the compat for the old way isn't
working. protocolbuffers/protobuf#9596
@ejona86
Copy link
Member Author

ejona86 commented Jun 29, 2022

@sergiitk, CI is still running, but it seems it is likely working now.

@ejona86
Copy link
Member Author

ejona86 commented Jun 29, 2022

Ugh. This is going to be a PITA to backport.

@ejona86 ejona86 merged commit c079028 into grpc:master Jun 30, 2022
@ejona86 ejona86 deleted the protobuf-3.21.1 branch June 30, 2022 18:18
ejona86 added a commit to ejona86/grpc-java that referenced this pull request Jun 30, 2022
ejona86 added a commit that referenced this pull request Jul 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GRPC Uses Outdated Version Of protobuf-java
2 participants